The Arcive of vBulletin Modifications Site.

powerful_rogue · #1 05-23-2009, 08:33 AM

Hi,

Im playing with the following code, but for some reason cant seem to get the "push" function to operate.

This is my code below

PHP Code:


			
<title>Image Array</title>

<SCRIPT LANGUAGE=JAVASCRIPT TYPE="TEXT/JAVASCRIPT">

adImages = new Array("images/banner/dods.gif","images/banner/dovermemorial1.gif","images/banner/doverlocals.gif","images/banner/DoverLifeboatBanner.gif")
adURL = new Array("dods.com", "dover.gov.uk","doverlocals.co.uk","lifeboat.org.uk")

thisAd = 0
imgCt = adImages.length

  
function rotate() {
  if (document.images) {
  thisAd++
  if (thisAd == imgCt) {
  thisAd = 0
  }
  document.adBanner.src=adImages[thisAd]
  setTimeout("rotate()" , imgCt * 1000)
  }
  
  }
  
function newLocation() {
 document.location.href = "http://www." + adURL[thisAd]
 }
  adImages.push("images/banner/freecycle.jpg")
  adURL.push("freecycle.org")

  </script>
  
</head>

<BODY BGCOLOUR=BLUE onLoad="rotate()">
<center>
<A HREF="javascript:newLocation()">
<IMG SRC="images/banner/dods.gif" WIDTH=468 HEIGHT=60 NAME="adBanner" BORDER="0"></A>

</center>
</body>
</html>

I want to be able to add a banner onto the end of adImages and a webaddress onto the end of adURL

The current arrays work fine, however I cant seem to get the new ones in the push command to be added!

Any help greatly appreciated!

UKBusinessLive · #2 05-25-2009, 06:55 PM

Hiya PR

I noticed you have a few minor errors in your code this is what the top half should look like

PHP Code:


			
adImages = new Array("images/banner/dods.gif","images/banner/dovermemorial1.gif","images/banner/doverlocals.gif","images/banner/DoverLifeboatBanner.gif"");

adURLS = new Array("http://www.dods.com","http://www.dover.gov.uk","http://www.lifeboat.org.uk" );

thisAd = 0;

imgCt = adImages.length;



function rotate() {

if (document.images) {

thisAd++;

if (thisAd == imgCt) {

thisAd = 0;

}

document.adbanner.src=adImages[thisAd];

document.getElementById('ad').href = adURLS[thisAd];

setTimeout("rotate()", 14 * 1000);

}

}

Try not to use too many white spaces with Javascript, and don't leave the semi colons out neither

Code:

imgCt = adImages.length;

Plus the url's will need to be the full urls complete with http://www etc....

Try changing your code to the above and see if you can get it to work, i would imagine your creating some form of banner slideshow??

Hope this helps, let us know the result

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.05186 seconds Memory Usage 4,658KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)ad_showthread_firstpost (1)ad_showthread_firstpost_sig (1)ad_showthread_firstpost_start (1)bbcode_code (2)bbcode_php (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)navbar (3)navbar_link (120)option (2)post_thanks_box (2)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (2)post_thanks_postbit_info (2)postbit (2)postbit_onlinestatus (2)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages: