Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Programming Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 01-17-2009, 07:53 AM
Voltar Voltar is offline
 
Join Date: Mar 2006
Location: Bakersfield, California
Posts: 77
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Auto Template Change Help

So since upgrading to vB 3.8.0 I've been recoding all of my hacks and template modifications to use plugins and I've ran into a bit of an issue. One of the little things that I do is remove the version number from public display, which requires a phrase edit/translation and editing the generator meta tag in the headinclude template.

After reading This, This and This, and making progress on my other mods, I ran into a problem where I can't get a change to take place in the headinclude template, no matter what hook I try.

This is what I've been trying...
PHP Code:
$gen_find '<meta name="generator" content="vBulletin $vboptions[templateversion]" />';
$gen_replace '<meta name="generator" content="vBulletin" />';
$vbulletin->templatecache['headinclude'] = str_replace($gen_find$gen_replace$vbulletin->templatecache['headinclude']); 
I've also tried every combination of escaping and quoting that I can think of, and even using the the version number added in manually (with a hook after parse_templates), and even using $vbulletin->options['templateversion'] concatenated into the string. Any ideas?


Also, is there a simple/easy/proper way to directly concatenate two templates together?
Reply With Quote
  #2  
Old 01-17-2009, 08:33 AM
Andreas's Avatar
Andreas Andreas is offline
 
Join Date: Jan 2004
Location: Germany
Posts: 6,863
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You should never-ever manipulate the tamplate cache.
Not only does this generate unnecessary overhead, it also causes a lot of problems for users who cache templates.

Use template hooks instead if possible, if not just instruct the users to modify the templates by hand.
Reply With Quote
  #3  
Old 01-17-2009, 10:29 AM
Voltar Voltar is offline
 
Join Date: Mar 2006
Location: Bakersfield, California
Posts: 77
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I know a few of the mods I currently have installed modify the template cache, and I was going from the articles. A few of the mods are solely for one of my boards, which I have several styles on, trying to make upgrading simpler.

So instead of modifying the template cache I should modify $headinclude, $header, $footer, etc if no hook exists?
Reply With Quote
  #4  
Old 01-17-2009, 01:22 PM
Andreas's Avatar
Andreas Andreas is offline
 
Join Date: Jan 2004
Location: Germany
Posts: 6,863
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yes, that would be a lot better (performance wise).
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 11:48 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.08998 seconds
  • Memory Usage 2,188KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (4)post_thanks_box
  • (4)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (4)post_thanks_postbit_info
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete