Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 12-12-2007, 07:22 PM
imageconstrux imageconstrux is offline
 
Join Date: Jan 2003
Posts: 78
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Right Hand Column in Showthread

I'm in the middle of upgrading from 2.2.9 to 3.6.8 - so far everything is going very well, but I've run into a snag I'm hoping someone can help with.

Using the ideas behind a very old template mod I was able able to create side columns in forumhome and forumdisplay pretty easily, and they're integrated nicely into the rest of the page. The template changes in essence are within forumhome and forumdisplay, I just added a table that wraps around the main body (but not the header or footer) and makes that one cell, and the side column the next cell.



That is except for showthread. I am all over the map on that one.

Here are the things I've done/altered to try to make a similar side column work:
  • Created a replacement variable for $spacer_open, then modified the postbit_wrapper template so that each time the postbit_wrapper template calls for the outertablewidth, it only gets the width I want that column to be.
  • Double-checked padding and margin issues - those don't seem to be it.

Any ideas of how I might edit Showthread or other templates to get myself a nice, clean looking side column?

The Ultimate Side Column hack is nice in it's simplicity to install, but it is called from the header, which for contextual advertising purposes (like Adsense), it's difficult to get relevant ads when the ad is generated before the content of the thread. Also, it reduces my ability to wrap ads snugly around the content like they are in Forumhome and Forumdisplay.

Sorry for the length of the post. Ask any questions for clarification.

Thanks in advance for your help.
Reply With Quote
  #2  
Old 12-12-2007, 07:34 PM
imageconstrux imageconstrux is offline
 
Join Date: Jan 2003
Posts: 78
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Here's a screen shot of the problem -

Notice the posts are the full width of the header, where they should only be about 3/4. Also, the footer has gone AWOL, as has the two adsense ads at the bottom, which are supposed to be just below the nav/breadcrumb.
Reply With Quote
  #3  
Old 12-12-2007, 08:12 PM
imageconstrux imageconstrux is offline
 
Join Date: Jan 2003
Posts: 78
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

After running the page through W3C validation, I may have caught something - it looks like the table I created is spilling over the closure of some <div>s.

I'll continue to peck away at this, but would love any input you might provide.
Reply With Quote
  #4  
Old 12-20-2007, 04:39 PM
imageconstrux imageconstrux is offline
 
Join Date: Jan 2003
Posts: 78
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

For anyone else looking into this, the problem seems to lie in the spacer_open template, specifically the conditional for old IE browsers. While it shouldn't affect non IE or current (6+) IE browsing, it does, and there isn't a closing conditional in spacer_close (but it wouldn't matter, because when I added one in, it still didn't work). Remove the conditional and you'll be a long way toward making this template mod work.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 04:18 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03481 seconds
  • Memory Usage 2,184KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (4)post_thanks_box
  • (4)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (4)post_thanks_postbit_info
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete