Whats wrong with this query?

[Xplorer4x4]

Can some one tell me whats wrong with this query?

PHP Code:

$db_site->query("UPDATE " . TABLE_PREFIX . "setting SET value='' WHERE varname='cookiedomain'");
$db_site->query("UPDATE " . TABLE_PREFIX . "setting SET value='/' WHERE varname='cookiepath'"); 


[Eikinskjaldi]

Nothing. It's perfect in every way.

[Farcaster]

Shouldn't it be using, $db->query_write ?

[Eikinskjaldi]

Originally Posted by Farcaster

Shouldn't it be using, $db->query_write ?

Only for code style issues. ->query still works. Of course down the track vb may change its mind on that, and make query unavailable.

[Paul M]

Originally Posted by Farcaster

Shouldn't it be using, $db->query_write ?

Yes.

Query should not be used at all, either for reading or writing.

* @deprecated	Deprecated as of 3.6. Use query_(read/write)

[Xplorer4x4]

Originally Posted by Farcaster

Shouldn't it be using, $db->query_write ?

PHP Code:

$db->query_write("UPDATE " . TABLE_PREFIX . "setting SET value='' WHERE varname='cookiedomain'");
$db->query_write("UPDATE " . TABLE_PREFIX . "setting SET value='/' WHERE varname='cookiepath'"); 


So is this the correct way?

[Chris M]

Yes that is correct

Chris