Board Optimization - (Forumdisplay) Turn off announcements & save 1 query

(Forumdisplay) Turn off announcements & save 1 query

What does this product do?

This very easy to use product turns off announcements in forumdisplay and saves a whole query each time forumdisplay is presented. Therefore it improves forum speed. There is a discussion in suggestion forum of vbulletin.com to only search for new announcements once a day instead of searching for new announcements each time forumdisplay is presented.

Installation information

• Files edited: 1
• Templates edited: 0
• Files to upload: 0
• DB Tables changed: 0
• Additional queries: 0
• Changed queries: 0
• Time to install: 60 seconds max

Installation

1. Open forumdisplay.php
   
2. Search for
   

   $announcements = $db->query_read_slave("
   		SELECT
   			announcement.announcementid, startdate, title, announcement.views,
   			user.username, user.userid, user.usertitle, user.customtitle, user.usergroupid,
   			IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid, infractiongroupid
   			" . (($vbulletin->userinfo['userid']) ? ", NOT ISNULL(announcementread.announcementid) AS readannounce" : "") . "
   		FROM " . TABLE_PREFIX . "announcement AS announcement
   		" . (($vbulletin->userinfo['userid']) ? "LEFT JOIN " . TABLE_PREFIX . "announcementread AS announcementread ON (announcementread.announcementid = announcement.announcementid AND announcementread.userid = " . $vbulletin->userinfo['userid'] . ")" : "") . "
   		LEFT JOIN " . TABLE_PREFIX . "user AS user ON(user.userid = announcement.userid)
   		WHERE startdate <= " . TIMENOW . "
   			AND enddate >= " . TIMENOW . "
   			AND " . fetch_forum_clause_sql($foruminfo['forumid'], 'forumid') . "
   		ORDER BY startdate DESC, announcement.announcementid DESC
   		" . iif($vbulletin->options['oneannounce'], "LIMIT 1"));

3. Delete this code
   
4. Save forumdisplay.php
   

Flagged for future version

• Put an IF { } statement around this, and create a new setting in vBulletin Options to control whether the Announcement is on or off in Forumdisplay.

Please click Install if you installed this product. So you can get information if product improves. Thank you.

This hack may not be copied, reproduced or published elswhere without my permission.
Please take attention: I take no responsibility for anything of what this product could do anywhere (forum, other software, server ...).

[ThorstenA]

Reserved for future posts.

[thincom2000]

I think it may be better to put an IF { } statement around this, and create a new setting in vBulletin Options to control whether the Announcement is on or off in Forumdisplay. That way you can actually use them if you need to, instead of deleting it entirely from the file.

[projectego]

Nice work, ThorstonA. Thanks.

Just curious though - does implementing this have any negative side-effects?

[ThorstenA]

Originally Posted by thincom2000

I think it may be better to put an IF { } statement around this, and create a new setting in vBulletin Options to control whether the Announcement is on or off in Forumdisplay. That way you can actually use them if you need to, instead of deleting it entirely from the file.

Flagged for future version

Originally Posted by projectego

Nice work, ThorstonA. Thanks.

Just curious though - does implementing this have any negative side-effects?

You do not see announcements on forumdisplay. That's the only effect and it saves one query

[JohnBee]

I did this MOD, I had 10 queries before I added the mod and I had 10 queries after the edit.
No effect that I can see.

[ThorstenA]

Originally Posted by JohnBee

I did this MOD, I had 10 queries before I added the mod and I had 10 queries after the edit.
No effect that I can see.

It is removing 1 query:

SELECT
			announcement.announcementid, startdate, title, announcement.views,
			user.username, user.userid, user.usertitle, user.customtitle, user.usergroupid,
			IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid, infractiongroupid
			" . (($vbulletin->userinfo['userid']) ? ", NOT ISNULL(announcementread.announcementid) AS readannounce" : "") . "
		FROM " . TABLE_PREFIX . "announcement AS announcement
		" . (($vbulletin->userinfo['userid']) ? "LEFT JOIN " . TABLE_PREFIX . "announcementread AS announcementread ON (announcementread.announcementid = announcement.announcementid AND announcementread.userid = " . $vbulletin->userinfo['userid'] . ")" : "") . "
		LEFT JOIN " . TABLE_PREFIX . "user AS user ON(user.userid = announcement.userid)
		WHERE startdate <= " . TIMENOW . "
			AND enddate >= " . TIMENOW . "
			AND " . fetch_forum_clause_sql($foruminfo['forumid'], 'forumid') . "
		ORDER BY startdate DESC, announcement.announcementid DESC
		" . iif($vbulletin->options['oneannounce'], "LIMIT 1")

[Zia]

any vb developer has anything to say about it?

[ThorstenA]

Originally Posted by Zia

any vb developer has anything to say about it?

vb Team is looking forward to put this query into datastore (or something like that) and just run this query once a day instead of every time forumdisplay is presented to user. Could be integrated into next smaller vbulletin update.

[Fenriz]

vb Team is looking forward to put this query into datastore (or something like that) and just run this query once a day instead of every time forumdisplay is presented to user. Could be integrated into next smaller vbulletin update.

Has that been done in 3.7.x?