Miscellaneous Hacks - Disallow HTML code in Thread Titles

Disallow HTML code in Thread Titles v1.01

Originally Posted by Staff Note

Staff Note:
Unmodified vBulletin will not evaluate HTML in thread titles. Using this modification without a hack installed that has security vulnerabilities is useless.

Also installing this modification, even with a modification installed that would make your board vulnerable to this type of HTML posting in thread titles, only will give you a false sense of security since there are many other options to exploit this, even without the use of the ">" character.

Everyone is encouraged to remove or update the vulnerable modification instead of using this hack.

Marco van Herwaarden.

By Jason Williams/Andrew Calderbank
03/09/2006

Recently there has been a spate of members posting html redirection code in thread titles, which when parsed on the forum homepage runs and redirects to whatever site they insert into the title.

This code simply disallows the characters < and > from being used in the thread titles, this is also is checked when editing the post.

It's fairly simple but puts to and end members signing up and posting redirect links. I don't know whether you'd class this as a hack or bug fix, but I hope this helps other members who are frustrated with this issue.

2 file edits
1 new phrase

Should be fairly straightforward to install.

**ALWAYS BACK UP FILES BEFORE YOU EDIT THEM!!**

v1.00

Original release

v1.01

Slight code update

[steadicamop]

Reserved for updates

[Puck 24/7]

Good idea, steadicamop.

edit: there seems to be a problem in: /includes/functions_newpost.php find:

error:
Warning: preg_match(): Delimiter must not be alphanumeric or backslash in /includes/functions_newpost.php on line 379

[steadicamop]

Originally Posted by Puck 24/7

Good idea, steadicamop.

edit: there seems to be a problem in: /includes/functions_newpost.php find:

error:
Warning: preg_match(): Delimiter must not be alphanumeric or backslash in /includes/functions_newpost.php on line 379

Ok, replace the code for this:

	elseif (preg_match('/<|>/',$vbulletin->GPC['title']))
	    eval(standard_error(fetch_error('nohtml')));

That should solve it.

[Paul M]

Both those files have hooks, can these changes not be done via plugins ?

[steadicamop]

I'll look into remaking it as a plugin - I've never dealt with creating plugins before so it's something I will have to my research on.

[Snake]

Thanks for this!

[Paul M]

Okay, just asking.

I think far more people are likely to make use of it if no file edits are involved.

[steadicamop]

Originally Posted by Paul M

Okay, just asking.

I think far more people are likely to make use of it if no file edits are involved.

Something I'm going to try and do right now

[DementedMindz]

so even if you dont allow html they can still post html in thread titles? if thats the case it seems strange that vbulletin wouldnt patch that. as you could just do this all day long with a google search finding vbulletin sites. would suck to have to use a plugin, hack, php file edit what ever to stop it and secure your site.