Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Programming Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 07-26-2006, 08:38 PM
The-Ensemble's Avatar
The-Ensemble The-Ensemble is offline
 
Join Date: Jul 2006
Location: United Kingdom
Posts: 278
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Something is effecting the spacers in this code . . .

I created a scheme with a random image generator (via javascript/html) inside it.
and something seems to making the spacers just go so the forums are full width. i can't get them to go to the size i want is there something in this code that could effect the spacers?:
HTML Code:
<script language="JavaScript">
<!-- HIDE FROM INCOMPATIBLE BROWSERS
document.writeln('<td'+' border=0 ><img src="'+xoxo[choice]+'" align=right height=253 width=486 border=0 ><'+'/td>');
// STOP HIDING FROM INCOMPATIBLE BROWSERS -->
</script>

-----------------------------------

<script language="JavaScript" type="text/javascript">
<!-- HIDE FROM INCOMPATIBLE BROWSERS

var ic = 2;
var xoxo = new Array(ic);

xoxo[0] = "";
xoxo[1] = "";

function pickRandom(range) {
if (Math.random) {
return Math.round(Math.random() * (range-1));
}
else {
var now = new Date();
return (now.getTime() / 1000) % range;
}
}

var choice = pickRandom(ic);
// STOP HIDING FROM INCOMPATIBLE BROWSERS --></script>
<script type="text/javascript" src="clientscript/vbulletin_global.js"></script>
Reply With Quote
  #2  
Old 07-27-2006, 02:33 AM
Code Monkey's Avatar
Code Monkey Code Monkey is offline
 
Join Date: May 2004
Posts: 1,080
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You should be using DOM for this.

PHP Code:
//find the row you want to atach the image to.
target_row document.getElementById('target_rows_id');
img_col document.createElement('td');
img_col.style.border 0;

new_img document.createElement('img');
new_img.setAttribute('src') = xoxo[choice];
new_img.style.align 'right';
new_img.style.height 253;
new_img.style.width 486;
new_img.style.border 0;

img_col.appendChild(new_img);
if(
target_row.firstChild){
    
target_row.removeChild(target_row.firstChild); //remove any prior image you set.
}
target_row.appendChild(img_col); 
Or better yet, just hard code the collumn and image in the html and give it an id attribute. then just swap out the image src.
Reply With Quote
  #3  
Old 07-27-2006, 11:36 AM
The-Ensemble's Avatar
The-Ensemble The-Ensemble is offline
 
Join Date: Jul 2006
Location: United Kingdom
Posts: 278
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Hi sorry whats DOM?
Reply With Quote
  #4  
Old 07-27-2006, 01:31 PM
Code Monkey's Avatar
Code Monkey Code Monkey is offline
 
Join Date: May 2004
Posts: 1,080
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Document Object Model. It's they way you should be writing to the browser screen.
Reply With Quote
  #5  
Old 07-27-2006, 07:49 PM
The-Ensemble's Avatar
The-Ensemble The-Ensemble is offline
 
Join Date: Jul 2006
Location: United Kingdom
Posts: 278
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ok. so do i replace my script with that or what?
Sorry if i appear really stupid im new at this.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 12:39 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.07032 seconds
  • Memory Usage 2,206KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)bbcode_html
  • (1)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (5)post_thanks_box
  • (5)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (5)post_thanks_postbit_info
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete