[BUG] Tournament ladder

Seems as though my members are not moving up to the next round sometimes.

Before I had players not moving from 1st round up to 2nd round. Now They seem to be not moving from 2nd round to 3rd round (finals).

Aslo, if member1 beats member2, member1 goes above member3 and member4 in the next round.

Here's what it looks like (click to enlarge, of course):


As you can see in the 1st round, jessicajoanne moved above cyberhypnotic's 1st match when she won and I moved above hers when I won. Then moxdevil won the 2nd round and moved above jessicajoanne and cyberhypnotic's 2nd match.

Also, jessicajoanne won the 2nd round, but it won't move her up.

Any suggestions?

One last thing, is the tournament fixed to be playable on IE?

[MrZeropage]

Tournaments are playable in IE, yes


The sorting in each line depends on the UserID, this means your 2nd round with 4 players left is sorted by UserID from left to right. That's why "jessicajoanne" moved leftmost, seems this user has the lowest UserID.
This User also should move up to the Final, that's right... Hmmmm, I will check this again.

Please test 2- and 4-player-Tournaments, they should work well ?

[cyberhypnotic]

2 Player tournament worked fine. I'll check on the 4 Player tourney.

Here's the thing. You said the users are moved according to UserID?

Well, by UserID, they are lined up jessicajoanne (11), cyberhypnotic (1), moxdevil (13), and nsewerin (14).

Same with the 1st round. As you can see, moxdevil is 13 and nsewerin is 14, but 69Charger is 50 and between them. :ermm:

This is just a guess, but this is my thoughts on it:

What if - moxdevil(13) moves up before jessicajoanne(11), therefore being organized according to UserID before jessicajoanne(11) is able to move up. Know what I mean? (13) took the place of (11), therefore leaving nowhere for (11) to go, so (11) sits in 2nd round waiting.

Another thing. Nothing big and major, just a typo. Some people might want to know how to fix it later on though:

In arcade.php (root folder), if you look for one time:

{$playerinfo[3]['timesplayed']}{$ibforums->lang['tourneytxt1']}

and replace with:

{$playerinfo[3]['timesplayed']}{$ibforums->lang['tourneytxt2']}

The difference is the number in tourneytxt. It makes the one tournament cell "studder" by repeating the text for line one over. (has playedhas played)

[MrZeropage]

Hmmm, did you upgrade to v2.5.4+ and have the actual arcade.php ?

[cyberhypnotic]

Yes, I had version 2.5.3 installed from a fresh install originally. Then when you released 2.5.4, I followed instructions exactly as given.

I've had this problem, even in version 2.5.3. I'm actually surprised nobody else complained about it, which kinda makes me think it's something with my copy only.

Do you suggest an uninstall and then a fresh install? Should I delete everything from my server, including games? Making it like it never existed? Then do a brand new fresh install?

Or are you still looking into the code? Is there any possible way to stop the code from ordering by member ID? That way, the winner of each round just moves up to their respective next round in the ladder?

[Reece^B]

MR.Zeropage

Im getting this error:

There is a SQL error.
You can contact the board administrator by clicking here

Error Returned
mySQL query error: SELECT userid, username FROM user WHERE userid IN() ORDER BY userid mySQL error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ') ORDER BY userid' at line 1 mySQL error code: Date: Sunday 22nd of January 2006 03:11:51 PM

We apologise for any inconvenience

This happens when I created a two player T and when it redirects me.

[MrZeropage]

@cyberhypnotic:
I can confirm that there sometimes is a problem with 8-player-tournaments, but I am not sure how to reproduce it. This now is on the "Bug-List" and I will look for a fix.
The sorting is another thing I'd like to change, and as there are many planned improvements for the Tournament-System I guess this will come along with that.


@Reece B:
Create the Tournament in AdminCP instead of ModCP and the Error won't show up
Will fix the ModCP in v2.5.5+

[cyberhypnotic]

MrZeropage, could you tell me which part of the code deals with sorting? Maybe I can take a look at it and if it looks doable for me, I can alter it to disable the sorting.

I can just comment out the sorting portion of the script.

[Reece^B]

Okay cheers mr.zeropage!

[MrZeropage]

@cyberhopnotic:
Here is the Code that generates the Tournament-View:

 for($i=1; $i<=$numrungs; $i++) {
$DB->query("SELECT m.name, t.timesplayed, t.rungscore, t.mid, t.rung, t.faceoff FROM ibf_tournament_players as t, ibf_members as m WHERE t.tid=".$tid." AND t.rung=".$i." AND m.id=t.mid ORDER BY t.faceoff ASC");
$ctr=0;
$refctr = 0;
while($refctr <= 7) {
$playerinfo[$refctr]['name'] = "";
$playerinfo[$refctr]['timesplayed'] = 0;
$playerinfo[$refctr]['rungscore'] = 0;
$playerinfo[$refctr]['playlink'] = "";
$refctr++;
}
while($row = $DB->fetch_row()) {
if(($ctr == 0 || $ctr == 1) && $row['faceoff'] == 2) {
$ctr = 2;
}
$playerinfo[$ctr]['name'] = $row['name'];
$playerinfo[$ctr]['timesplayed'] = $row['timesplayed'];
$playerinfo[$ctr]['rungscore'] = $row['rungscore'];
if($row['timesplayed'] < 3 && $ibforums->member['id'] == $row['mid']) {
$playerinfo[$ctr]['playlink'] = "<a href='".$ibforums->base_url."act=Arcade&do=playtourney&gameid=".$tinfo['gid']."&tid=$tid&rung=".$row['rung']."'>".$ibforums->lang['play']."</a>";
} else {
$playerinfo[$ctr]['playlink'] = "";
}
$ctr++;
}
$this->output .= $this->define_ladder($i, $playerinfo);
}

I marked the Query+Sorting.

As you see the concept seems to be the problem, as it is sorted by "faceoff" (Match1, Match2 ...) which is ok but is not looking up in which faceoff/Match this player was in the last round ("rung").

I guess this can only be solved by one additional query ...