New vB3 script is out

[filburt1]

<a href="http://www.vbulletin.com/forum/showthread.php?threadid=73163" target="_blank">http://www.vbulletin.com/forum/showt...threadid=73163</a>

[assassingod]

No table or column conflicts, i'm all set for vB3

[colicab-d]

im good too

[N9ne]

Yep I saw this just after it was posted, no conflicts on my end either, didn't expect any

[filburt1]

BTW, based on this script, i still have to say the devs aren't making good enough code. I know I sound like an a-hole, but what I see:

1. 1 and 0 everywhere instead of true and false
2. STILL using array keys not in strings
3. Exceeding 80-char line limit

However it's a billion times better than vB2, nobody can argue with that.

[Freddie Bingham]

Today at 02:02 PM filburt1 said this in Post #6
BTW, based on this script, i still have to say the devs aren't making good enough code. I know I sound like an a-hole, but what I see:

1. 1 and 0 everywhere instead of true and false
2. STILL using array keys not in strings
3. Exceeding 80-char line limit

However it's a billion times better than vB2, nobody can argue with that.

I think we need to hire you as a developer so you can show us how it is done.

I'm still waiting to see you code a forum better than the "lowly" vB2 since you obviously think you have the skills. One would hope a moderator of the official hacking site would have a bit more respect.

[Scott MacVicar]

Today at 10:02 PM filburt1 said this in Post #6
BTW, based on this script, i still have to say the devs aren't making good enough code. I know I sound like an a-hole, but what I see:

1. 1 and 0 everywhere instead of true and false
2. STILL using array keys not in strings
3. Exceeding 80-char line limit

However it's a billion times better than vB2, nobody can argue with that.

That script doesn't reflect what the vB3 core looks like.
1. PHP treats 1/true and 0/false the same
2. The array keys not in strings, i couldn't find any of these in the scripts. Please do show me where it is.
3. The line limit is exceeded by some HTML which isn't in any of the vB code.

[filburt1]

I knew it would be taken with offense, none intended...

(although if you're serious I'm it )

I'm just quoting industry standards as well as what the PHP manual says.

[Freddie Bingham]

Today at 02:15 PM filburt1 said this in Post #9
I knew it would be taken with offense, none intended...

(although if you're serious I'm it )

I'm just quoting industry standards as well as what the PHP manual says.

I suppose you mean no offense every other time you make a post like this?

[filburt1]

Today at 05:10 PM Scott MacVicar said this in Post #8
That script doesn't reflect what the vB3 core looks like.
1. PHP treats 1/true and 0/false the same
2. The array keys not in strings, i couldn't find any of these in the scripts. Please do show me where it is.
3. The line limit is exceeded by some HTML which isn't in any of the vB code.

1. I know, but for readability, true/false sure is prettier
2. Line 327: "$index[Key_name]" should be $index['Key_name'], technically.
3. Lines 332, 335, and 346 are (mostly) PHP.