Miscellaneous Hacks - IE11 browser detection and fixes

IE11 gets along pretty well with vB3, though file downloads get a bit wonky due to some changes in how IE is detected.

In includes/functions.php find:

PHP Code:

        // detect macintosh 


Add above:

PHP Code:

// Detect Modern IE11+
        if (strpos($useragent, 'trident') !== false AND !$is['opera'] AND !$is['ie'])
        {
            preg_match('#rv:([0-9\.-]+)#', $useragent, $regs);
            $is['ie'] = $regs[1];
 
        } 


Next, find:

PHP Code:

if (strpos($useragent, 'gecko') !== false AND !$is['safari'] AND !$is['konqueror']) 


And replace it with

PHP Code:

if (strpos($useragent, 'gecko') !== false AND !$is['safari'] AND !$is['konqueror'] AND !$is['ie']) 


[BirdOPrey5]

Originally Posted by Digital Jedi

[minicode](Trident|MSIE)[/minicode] would match specifically one of those two words, but I don' know how that affects the JS.

My concern was the extra parentheses would throw off the rest of the script.

[Zachery]

Did anyone try?

[JamesC70]

Originally Posted by EvilLS1

Smileys don't seem to work in IE11/vB3.8 by clicking them in WYSIWYG mode. Works fine in compatibility mode. Any fix for this?

Originally Posted by Zachery

It appears that YUI will also need to be updated to handle the issues with the editor. Though, I don't know how reasonable that will be. I suspect we can just append similar code to the YUI file for browser matching. But I'm not overly familiar with js.

YUI has been updated: http://www.yuiblog.com/blog/2013/12/...14-1-released/ Has anyone at vB verified that this fixes the issue on 3-series forums? (Alternately: how badly would it screw up our sites if we used this one instead of YUI 2.9.0? )

[Zachery]

YUI 3, is not YUI 2, its not a drop in replacement. Moving to YUI 3 is about the same as moving to Jquery, or another similar js lib.

So yes, to get IE11 support in vBulletin fully, you'd need to update yui to support something it wasn't originally intended to.

[Boothby]

[Trident|MSIE]+

Sorry, but this makes no sense at all, because it would even match M or MM or MMMMMMMM or in an unbelievable worst case |||||. Uuuh.
The | has no meaning between []. The chars/letters are alternatives, so you could also write:

(T|r|i|d|e|n|t|\||M|S|I|E){1,}

So, after looking into the original source codes of YUI 2 and 3 I would suggest to replace

else{a=c.match(/MSIE\s([^;]*)/);if(a&&a[1]){g.ie=e(a[1]);}

with

else{a=c.match(/MSIE ([^;]*)|Trident.*; rv:([0-9.]+)/);if(a&&(a[1]||a[2])){g.ie=e(a[1]||a[2]);}

The browser detection is very similar in both, YUI 2 and 3 and the above code is from YUI3 and then backminified by me.

untested, hope it works

[cellarius]

What YUI version file do you use, Boothby? I don't have that line in my /clientscript/yui/yahoo-dom-event.js.

[Boothby]

I downloaded the latest version from yahoo, 2.9.0, and it seems identical to the latest stable and beta vBulletin builds. In an older build on my local install I found also Zachery's code which was from 2.7.0.

Here it is:

Find:

else{A=B.match(/MSIE\s([^;]*)/);if(A&&A[1]){C.ie=parseFloat(A[1]);}

and replace with:

else{A=B.match(/MSIE ([^;]*)|Trident.*; rv:([0-9.]+)/);if(A&&(A[1]||A[2])){C.ie=parseFloat(A[1]||A[2]);}

And again, not tested with best hopes.

[Zachery]

digitalpoint did some testing and he said the YUI 2.9 seemed to work, but again, its not supported by default.

[cellarius]

Thanks guys, appreciated! Shawn's word is good enough for me :-)

[Boothby]

YUI 2.9 is in the current download packages of vB 3.8.7 and 3.8.8.

/*
Copyright (c) 2011, Yahoo! Inc. All rights reserved.
Code licensed under the BSD License:
http://developer.yahoo.com/yui/license.html
version: 2.9.0
*/