vb.org Archive - Miscellaneous Hacks - IE11 browser detection and fixes

Page 1 of 4

Last »

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)

- - Miscellaneous Hacks - IE11 browser detection and fixes (https://vborg.vbsupport.ru/showthread.php?t=303520)

Zachery

10-16-2013 10:00 PM

IE11 browser detection and fixes

1 Attachment(s)

IE11 gets along pretty well with vB3, though file downloads get a bit wonky due to some changes in how IE is detected.

In includes/functions.php find:

PHP Code:


		
			
        // detect macintosh

Add above:

PHP Code:


		
			
// Detect Modern IE11+
        if (strpos($useragent, 'trident') !== false AND !$is['opera'] AND !$is['ie'])
        {
            preg_match('#rv:([0-9\.-]+)#', $useragent, $regs);
            $is['ie'] = $regs[1];
 
        }

Next, find:

PHP Code:


		
			
if (strpos($useragent, 'gecko') !== false AND !$is['safari'] AND !$is['konqueror'])

And replace it with

PHP Code:


		
			
if (strpos($useragent, 'gecko') !== false AND !$is['safari'] AND !$is['konqueror'] AND !$is['ie'])

Zachery

10-17-2013 04:35 PM

You do that then...

Max Taxable

10-17-2013 04:36 PM

But only if it's okay with you. :D

BirdOPrey5

10-17-2013 05:09 PM

Only the mod author is allowed 1 reserved post directly below their modification post. Reserved posts aren't permitted elsewhere on the site.

Max Taxable

10-17-2013 07:27 PM

Quote:

Originally Posted by BirdOPrey5 (Post 2454207)

Only the mod author is allowed 1 reserved post directly below their modification post. Reserved posts aren't permitted elsewhere on the site.

Ahh, live and learn! I always thought it was for the purpose of subscribing to a thread to make it easy to find later! Reserving installation for a later time but keeping track of progress in the thread.

NOW I understand.

Zachery

10-17-2013 08:09 PM

TAg, or install it, if you want to keep dibs on it :)

Zachery

11-20-2013 07:28 PM

Made a small change to fix a IE10 detection issue.

cellarius

12-02-2013 10:12 AM

Thanks, Zachery! Installed. Do you know whether this will be included into vB3.8.8 before release? Just so I know whether I'll have to remember to redo it after an eventual upgrade.

Zachery

12-02-2013 03:45 PM

I don't think so, I haven't asked about it. But the fix is fairly trivial at least.

BirdOPrey5

12-03-2013 06:36 PM

A bug for IE11 detection is marked as resolved in JIRA-
http://tracker.vbulletin.com/browse/VBIII-12932

Looks like it would fix this issue.

All times are GMT. The time now is 02:02 PM.

Page 1 of 4

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01113 seconds Memory Usage 1,737KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (4)bbcode_php_printable (1)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (2)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: