Convert Secondary UserGroup to Primary UserGroup

[steven s]

Originally Posted by MarcoH64

I might have a look at it. Bump me again if i forget.

Bumping. Think this will work in 3.5?

Edit: I figured I'd give it a go. It seems to work.

[axi]

works like a dream xcept one of my primary users in that group wont get the message, why is that?? wierdf!

[Marco van Herwaarden]

If only 1 didn't get the message, the problem must be on his side.

[axi]

no no, you know how in vBulletin it shows who has been emailed, well over there.. it didnt list his name... why?? he is primary of that group.

[Marco van Herwaarden]

Sorry i don't understand you.

[Warlock40]

great hack. thought it was working on 3.5.4
but get this error when try to send out an email

Database error in vBulletin 3.5.4:

Invalid SQL:

				SELECT user.userid, user.usergroupid, user.username, user.email, user.joindate,
					useractivation.activationid
				FROM user AS user
				LEFT JOIN userfield AS userfield ON (userfield.userid = user.userid)
				LEFT JOIN usertextfield AS usertextfield ON (usertextfield.userid = user.userid)
				LEFT JOIN useractivation AS useractivation ON (useractivation.userid = user.userid AND useractivation.type = 0)
				WHERE 
		1=1 AND (usergroupid = 6 OR usergroupid = 7 OR usergroupid = 50 OR usergroupid = 46 OR usergroupid = 51 OR usergroupid = 2 OR find_in_set(6, membergroupids) OR find_in_set(7, membergroupids) OR find_in_set(50, membergroupids) OR find_in_set(46, membergroupids) OR find_in_set(51, membergroupids) OR find_in_set(2, membergroupids))
		AND user.email <> ''
		
				ORDER BY userid
				LIMIT 0, 500;

MySQL Error  : Column: 'usergroupid' in where clause is ambiguous
Error Number : 1052

[Warlock40]

no support? No worries. removed the code from my forum. Good idea. Wish I could get it to go with 3.5.4.

[tylneyt]

Originally Posted by MarcoH64

I got a better solution for you

Do the following modifications in your includes/adminfunctions_user.php (2 edits) and you will be able to select your users for the mailing also based on secondary membergroups.

In file includes/adminfunctions_user.php

Find:

PHP Code:

        print_membergroup_row($vbphrase['primary_usergroup'], 'user[usergroupid]', 2, $userarray); 


Add under:

PHP Code:

        // Start hack MarcoH64
        print_membergroup_row($vbphrase['additional_usergroups'], 'user[membergroupids]', 2, $userarray);
        // End hack MarcoH64 


In the same file find:

PHP Code:

    if (is_array($user['usergroupid']))
    { // for emails
        foreach($user['usergroupid'] AS $id)
        {
            $u_condition[] = "usergroupid = $id";
        } 


REPLACE by:

PHP Code:

    // Start hack MarcoH64
    if (is_array($user['usergroupid']) OR is_array($user['membergroupids']))
    { // for emails
        if (is_array($user['usergroupid']))
        {
            foreach($user['usergroupid'] AS $id)
            {
                $u_condition[] = "usergroupid = $id";
            }
        }
        if (is_array($user['membergroupids']))
        {
            foreach($user['membergroupids'] AS $id)
            {
                $u_condition[] = "find_in_set($id, membergroupids)";
            }
        }
        // End hack MarcoH64 


As usual test first on a test board, only limited tested by me.

there needs to be a line added for 3.5.4, then it works just fine:

REPLACE by:

PHP Code:

// Start hack MarcoH64 
    if (is_array($user['usergroupid']) OR is_array($user['membergroupids'])) 
    { // for emails
// start addition, by tylneyt
// this line is necessary to create the variable in this scope
//
        $u_condition = array();
// end addition 
        if (is_array($user['usergroupid'])) 
        { 
            foreach($user['usergroupid'] AS $id) 
            { 
                $u_condition[] = "usergroupid = $id"; 
            } 
        } 
        if (is_array($user['membergroupids'])) 
        { 
            foreach($user['membergroupids'] AS $id) 
            { 
                $u_condition[] = "find_in_set($id, membergroupids)"; 
            } 
        } 
        // End hack MarcoH64 


hope that helps, should actually be a standard feature of next vB if you ask me!

[smdani]

I’ve same problem https://vborg.vbsupport.ru/showthrea...473#post975473
MySQL Error : Column: 'usergroupid' in where clause is ambiguous
Error Number : 1052

Tylneyt I’d hoped that your add will help me but after the code modification, the problem persists
?Any idea of what I would do?
I’m running vb 3.5.0 with MarcoH64’s modification

I don’t want to undo the MarcoH64’s code edition as it is very useful in my forum, but now I can’t send mails to primarygruop members

[Panzer Max]

That works beautifully! One would think this would be standard issue with vB.

Thanks!