Version specific PHP code?

[Darth Cow]

This code works just fine on localhost, running PHP 5.0.5. On the live site, running PHP 4.3.2, I get the following error:

Parse error: parse error, expecting `T_VARIABLE' or `'$'' in /var/www/html/includes/class_bbcode.php(149) : eval()'d code on line 14

PHP Code:

// Deck tag plugin by Stephan Hoyer
// http://www.sccs.swarthmore.edu/users/08/hoyer/decktag/
//
// Title: Custom bbcode tag WYSIWYG fix
// This code is necessary so that when using the WYSIWYG editor to edit a post,
// vBulletin does not attempt to still show the HTML in the editor (as it does for
// simple [url] or [b] tags), but rather completely unparses the tags, returning
// the original tags around the contents of the post.
//
// vB3.5 hook location: bbcode_create

if (class_exists('vB_BbCodeParser_Wysiwyg') AND is_a($this, 'vB_BbCodeParser_Wysiwyg'))
{
    foreach ($this->tag_list AS &$option)
    {
        foreach ($option AS &$tag_name)
        {
            if ($tag_name['callback'] == 'handle_external')
            {
                $tag_name['callback'] = 'handle_wysiwyg_unparsable';
            }
        }
    }
} 


Any ideas why this isn't working? Line 14 is the first foreach line, but it seems to be perfectly well formed. I'm pretty sure the live site and my localhost copy are the same in all other relevant respects.

[Trigunflame]

I dont believe php 4 supports references in a foreach construct, which you shouldnt being using regardless.

The nature of foreach is to use a copy of an array and go through it key by key, if you want to operate on references, it would be better to use a for construct

$keys = count($array);
for ($i=0;$i<=$keys;$i++)
{
$option = &$array[$i];
}

and so on

[filburt1]

There's nothing wrong with using foreach in most cases. Passing damn near everything by reference introduces more opportunities to screw up the orignal data bacause you accidently modify one of the elements.

Knowing specifically what line 14 is would help.

[Trigunflame]

I was basing my reply to him on the knowledge of php4 object model specifically having problems with references in foreach constructs.

But you are right, nothing wrong with using foreach in most cases (cept large arrays where copying an array might cause excessive memory usage).