Question and Possible Bug

I just installed this on a fresh upgrade to 3.0.10 from Zero Tolerance's 1.5 hack. I had a bunch of trouble mainly with the upgrade script removing the old templates, adding the new ones, and then removing the new templates once I got the the apply database changes step.

I also noted that the upgrade didn't add a couple of phrases to the database and also didn't add the warn_notes field to the user table. I figured it all out by checking the install_warn script and finding the differences.

First off... GREAT hack... a much improved system over the original.

Now onto my question. I need to have the ability to allow any of my moderators to warn users in any forum. Or if that's not possible perhaps at least a few select forums I choose. Reason being we have certain forums which have such high traffic everyone of my 40+ moderators helps pitch in to moderate.

Now onto the possible bug. I don't have the moderation queues setup, but one of my users got this error today when trying to reply to a thread.

Warning: Unknown modifier '!' in /includes/functions_warning.php on line 707

That line looks to be a regex check... but I can't find a ! anywhere in the line. Also I asked the user and it appears he had sworn in the post (tripping one of my censored words to replace the word with ****) But I have the auto warning functions disabled, so I'm not sure why it would even call the warning fuctions.

Any help would be greatly appreciated. Thanks.

-Nick
http://www.nasioc.com/

EDIT: It in fact pops up this warning everytime you make a post with a censored work that the software changes.

[sv1cec]

I would suggest that you check the changes you have made in includes/functions_newpost.php, you must have left some ! there, somewhere.

As for your moderators issue, if a member is allowed to moderate a forum, he can warn other members, so it has to do more with how you set up your vB permissions, than anything else.

[NickCat]

Hey John,
I just started from a clean copy of functions_newpost.php and hacked from your directions, but I'm still getting the same error.

Why would you have suspected that file when the error says it's encountering a problem in the fuctions_warning.php?

And also in regards to the moderators... I understand how the permissions work, with the previous hack the warnings we're visible to all moderators in all forums. I assume it's just a matter of editing the if condition in the postbit, I just wanted to know if you had a more elegant solution before I go hacking up the postbit permissions you setup in the first place. Seems like it would be a pretty easy hack to add an if condition based on forum ids that would allow any moderator to warn in that forum.

With sites as large as mine... check NASIOC on big boards for confirmation... something like this would be very beneficial.

And yes I could manually add all 40+ of my moderators to the few forums that need the moderation... but thats a lot of extra permissioning for something that could be fixed with a small if statement.

-Nick

[sv1cec]

For the simple reason that there is no ! in that function and because that function is called from functions_newpost.php (function build_new_post). Also check your edits in newreply.php and newthread.php (depending on if the error occurs when entering a new post or a new thread).

As for your moderators question, you can alter the conditional to check for the moderator/smoderator/admin usergroups, instead of checking if the user can moderate the post, but then make sure that you do not use the hierarchical option, I am not even sure what problems can arise from such a change.