vBulletin 3.5.0 Almost

[Andreas]

*Looking up Paul M's Hookrequests*

[Mike Sullivan]

Originally Posted by Paul M

Oh, so my requests found the usual reject pile then.

I don't even think you've posted in that thread in the last month...

[Paul M]

Originally Posted by Mike Sullivan

I don't even think you've posted in that thread in the last month...

10 Days ago actually .......

http://www.vbulletin.com/forum/showp...&postcount=386

[Andreas]

From looking at the code, I think it should be possible to use Hooks

postbit_display_complete
member_complete
reputation_add
memberlist_bit

for what you want to do.

[KW802]

Originally Posted by KirbyDE

With some code changes it should be possible to make it edit-less, yes.
I can write up the instructions if you want.

Just saw your response over at vBa......

[high]* KW802 gets giddy like a little kid at the prospect of a totally edit-less vBa CMPS. :banana:[/high]

[Paul M]

Originally Posted by KirbyDE

From looking at the code, I think it should be possible to use Hooks

postbit_display_complete
member_complete
reputation_add
memberlist_bit

for what you want to do.

I'm sure it *might* be possible to fudge/kludge/bodge it using existing hooks, I'm also sure the same applies to many hooks already added. I do also use the reputation power function in another place besides it's normal use, so I'm not sure how that would work, duplicating code in multiple hook locations is not my idea of a good way to do things.

I have managed to kludge up a way to change the pips display - but it requires a minor template change (one btw that would not affect any normal vb installations workings, so it would be nice if it were a master change).

However, it's much easier, simpler and cleaner to have a hook in each function. It's a bit worrying (from the post above) that the request doesn't appear to have even been seen.

[deathemperor]

first I got "vBulletin 3.5 Scott done eat a Pizza"
now I got: "vBulletin 3.5 Almost"
and also with: vBulletin 3.5³
and: "vBulletin 3.5, now with coffee maker support!"

someone is making jokes !

lol, can't wait for the gold version.

[Mike Sullivan]

Originally Posted by Paul M

However, it's much easier, simpler and cleaner to have a hook in each function. It's a bit worrying (from the post above) that the request doesn't appear to have even been seen.

No, I saw it. I scrolled through a bunch of pages looking for your name and just missed it.

Regardless, I'm very wary of adding additional hooks to showthread, especially in looped areas due to overhead concerns. Hooks are not designed to account for every instance, remember.

[jugo]

Originally Posted by deathemperor

first I got "vBulletin 3.5 Scott done eat a Pizza"
now I got: "vBulletin 3.5 Almost"
and also with: vBulletin 3.5?
and: "vBulletin 3.5, now with coffee maker support!"

someone is making jokes !

lol, can't wait for the gold version.

I'm Waiting for them to put

vBulletin 3.5 Aww forget it...go back to 3.0.9

[Paul M]

Originally Posted by Mike Sullivan

Regardless, I'm very wary of adding additional hooks to showthread, especially in looped areas due to overhead concerns. Hooks are not designed to account for every instance, remember.

Yet there is a hook in the looped image fetch (reputation_image) which is called for every pip rather than just once per post. I know which would be more useful to me, and much less overhead. I wonder if anyone uses the reputation_image hook.

(fyi the bodge I referred to for my hack uses that hook plus the template change simply because it's all I can use, it would be far better to have one hook at the end of the function)