vb 3.5 and globalize()

[Mythotical]

Awesome, it worked great.

now for some reason its not keeping the linked users actually linked.

I am porting Quick Account Switch and the linking procedure in the admincp isn't keeping the users linked.

I am attaching the file that is used by the admincp, if you could Merk, please look it over and make sure I haven't made any mistakes that might be causing problems.

Thanks
Myth

I get the feeling something is up with this piece of code that I had to use when altering admincp/user.php

PHP Code:

    // Quick Account Switch 1.2 - Start
    $qas_is_slave=false;
    print_table_header($vbphrase['qas_version']);
    if (!empty($user['qas']))
    {
        $qas = unserialize($user['qas']);
        foreach ($qas as $qas_acct => $qas_acct_value)
        {
            if ('m'==$qas_acct_value['type']) // we are a master account to this slave account
            {
                $qas_link = "(<a href=\"user.php?$session[sessionurl]&do=edit&u=$qas_acct_value[userid]\">$vbphrase[profile]</a>)";
                // parameters: u2 (slave),  u (master)
                $qas_link .= " (<a href=\"qas.php?$session[sessionurl]&do=qasunlink&u=$user[userid]&u2=$qas_acct_value[userid]\">$vbphrase[qas_unlink]</a>)";
                print_label_row($vbphrase['qas_master_to'] . ' ' . base64_decode($qas_acct_value['username']), $qas_link);
            }
            else // we are a slave account to this master account
            {
                $qas_link = "(<a href=\"user.php?$session[sessionurl]&do=edit&u=$qas_acct_value[userid]\">$vbphrase[profile]</a>)";
                $qas_link .= " (<a href=\"qas.php?$session[sessionurl]&do=qasunlink&u=$qas_acct_value[userid]&u2=$user[userid]\">$vbphrase[qas_unlink]</a>)";
                print_label_row($vbphrase['qas_slave_to'] . ' ' . base64_decode($qas_acct_value['username']), $qas_link);
                $qas_is_slave = true;
            }
        }
    }
    else
    {
        print_label_row($vbphrase['qas_no_accounts'], '', '', 'top', 'noslaves');
    }
    if (!$qas_is_slave)
    {
        $qas_link = " <a href=\"qas.php?$session[sessionurl]&do=qaslink&u=$user[userid]\">$vbphrase[qas_add_to] $user[username]</a>";
        print_description_row($qas_link);
    }
    print_table_break('', $INNERTABLEWIDTH);
    
    // Quick Account Switch 1.2 - End 


EDIT: Attached code modifications needed for this hack and I think certain pieces are no longer used in vb 3.5 but I could be wrong I am using the right code.

[Marco van Herwaarden]

Please note that 'u' is one of the special shorthand variables (like f=forumid, p=postid, t=threadid,....) that get a special treatment.

[Mythotical]

Right Marco

Any idea why its not staying linked up?

Thanks
Myth

[Marco van Herwaarden]

Check if it is converted from 'u' to 'userid'.

[Mythotical]

How would I go about doing that? Is it a function that would do that or what?

Thanks Marco

Myth

[merk]

Sorry mate, I cant really see what the problem is (just by looking at code).

It looks reasonably okay to me, with a few minor habbit things that I would do differently, but i think Marco is right – The url variables you are using should be modified so they are not getting broken by vBulletin because it thinks that variable is its own.

You should change u to be more descriptive (qas_user1) or at least more unique.

The same should go for all variables you're using.

[Mythotical]

Tis ok Merk, I will try to change the variables but I'm afraid if I do that and not know where to change it in the file to make sure it reads it right then it will give me more errors than I want.

[pirotess]

I'm having no end of trouble converting my custom PHP scripts to work with the new vbulletin 3.5 code structure. Basically I have a form that calls itself to pass variables to my database. I'm using this to initialize the form variables at the top of my script:

$bbuserinfo = $vbulletin->userinfo;

$vbulletin->input->clean_array_gpc('p', array(
'name' => STR,
'gender' => INT,
'race' => INT,
'class' => INT,
'level' => INT,
'trade1' => INT,
'trade1skill' => INT,
'trade2' => INT,
'trade2skill' => INT,
));

Then using this to pass the variables to my database.

if ($submit) {
$tstamp = mktime();
$timestamp = date("Ymdhis", $tstamp);
$sql_result = mysql_query("UPDATE `wowmembers` SET
                            name='$vbulletin->GPC[name]',
                            gender='$vbulletin->GPC[gender]',
                            race='$vbulletin->GPC[race]',
                            class='$vbulletin->GPC[class]',
                            level='$vbulletin->GPC[level]',
                            trade1='$vbulletin->GPC[trade1]',
                            trade1skill='$vbulletin->GPC[trade1skill]',
                            trade2='$vbulletin->GPC[trade2]',
                            trade2skill='$vbulletin->GPC[trade2skill]',
                            lastupdate='$timestamp'
                            WHERE eqname='$bbuserinfo[username]'", $db);
}

Each of the variables in the initialization are used in various parts of the form as such.

<select name="race">

The form action is set to post but no matter what I do I get this error:

Call to a member function clean_array_gpc() on a non-object in script path line 5.

Anyone have any suggestions?

Tried moving the clean_array_gpc code to after my form but before the submit button with no change. Tried just using clean_gpc on each variable and it still gives me the non-object error on:

$vbulletin->input->clean_gpc('p', 'gender', INT);

I have no idea what the problem is.

[Marco van Herwaarden]

The types are not 'STR' naymore, but 'TYPE_STR', same for the other types.