[RELEASE vB2.0] Code Buttons and Clickable Smilies (major update)

I pasted it in in after <?php

on the second line that is..

isn't that right ?

Guess a developer should pop in..

I will see what I can do about putting this into beta 4. Please let me know when it is considered in a finished state so I can modify it as needed to add CP options. This functionality was on our todo list but we didn't have a chance to get around to it so it is on the 2.1 list but this one looks very nice so we can go ahead and use it.

If this is going to be included in beta4 I will do some cleaning-up of the code and check some more browsers.

I will also alter the text-prompts system to use a template, for multi-language capabilities.

I'll post back soon.

Originally posted by DeathLoad
I pasted it in in after <?php

on the second line that is..

isn't that right ?

Yes, that's right... what version of PHP are you using? As you can see, no one else (has reported) this error, so perhaps it's something wierd with your PHP version?

It needs to not break any browsers but it is acceptable if it doesn't work for everyone since it is javascript. I tested it with the webTV browser and had no major problems. I would have templateized it but if you want to go ahead

Okay, question:

When I am templatizing (new word of the day) the prompts, would you prefer to have one template which contains stuff like

bold_text = "prompt for bold text";
italic_text = prompt for italic text";
etc...

or to have lots of little templates for each prompt? The only problem I can forsee with having multiple templates is the fact that Javascript will freak if there are linebreaks in there.

I won't be adding the rest of the contents of vbcode.js to templates, as it seems like a huge waste of bandwidth to continually download the same static code for every posting. I'll be leaving that as an external javascript file.

We don't like lots of little templates unless it is something we really have to do.

Also I think I will add a user option to enable/disable using the Code Buttons and Clickable Smilies. I do forsee some power users being upset at being forced to view the options on their post entries.

Splendid.

In that case, I will templatize it like this:

• vbcode_prompts
  will contain the javascript prompts that appear in the prompt textbox
  
• vbcode_buttons
  will contain the main HTML for the buttons and menus
  
• vbcode_fontbits
  will contain the <option> bits for the fonts select
  
• vbcode_sizebits
  will contain the <option> bits for the font-size select
  
• vbcode_colorbits
  will contain the <option> bits for the font-color select
  
• vbcode_smilies
  will contain the table for the posting-page smilies
  
• vbcode_smiliebits
  will contain the individial smilies for the posting page
  
• vbcode_smilies_getmore
  will contain the button to launch the overflow smilies window
  
• popup_smilies
  will contain the HTML for the smilies popup window
  
• popup_smiliesbits
  will contain the individual smilies for the popup

Will that be acceptable?

That sounds fantastic!
I'm really looking forward to that!

Awsome hack!

Mines up @ http://forums.nzgn.net.nz/