The Arcive of Official vBulletin Modifications Site.

sv1cec · #12 05-31-2005, 06:41 PM

Exitilus, have you defined any warning types? And have you specified which one of them are non-post related?

Rgds

Exitilus · #13 05-31-2005, 09:37 PM

Aye. I created a Warning Called Bot. With 5 Warning Points (Which is the # set to Ban a User) and set Perma Ban to Yes

I set the Alert to NO. Even if I Disable Alerts. It still won't work and gives the same error message :|

sv1cec · #14 06-01-2005, 04:11 AM

I am not sure what to tell you. This error is coming from the hack files, not the ones of vB that you have edited, so it appears that either (a) something is wrong with the file or (b) something is wrong with your settings. If you want, give me access to your system and I'll try to figure it out (if it is not too well hidden).

To be on the safe side, please upgrade to the latest version.

Rgds

zell_11 · #15 06-04-2005, 08:22 AM

I am getting the exact same problem

sv1cec · #16 06-04-2005, 12:18 PM

Please be a little more specific. What problem? And which version of AWS are you currently running? If you are not running the latest, please upgrade to the latest version first and then see if the problem persists.

Rgds

kmike · #17 06-07-2005, 07:02 AM

Well, I see that the handling of alerts in the code is very prone to errors. It's in fact so broken that I don't even know how to start fixing it. I just put some bandaid hacks which disabled alerts altogether for us, as we don't need them.

First of all, the "alert" hidden form field in WarnUserNoPost and WarnUser forms (warn_addwarn and warn_addwarn_nopost templates) is never initialized at all, if alerts are disabled. It is supposed to be set to $_GET['alert'], but if alerts are disabled, no &alert=... parameter is being passed in URL to the forms, so "alert" form field stays empty.

So following the chain of events, this causes $alert global variable to be always empty in Warn.php script, in DoWarnUser and DoWarnUserNoPost sections. This in turn sets "if ($alert=='No')" condition in warn_calculations() function to true ($alert is empty, so it's not equal to "No"), and the execution of the script follows completely wrong code path from here, causing that bogus "This Warning Type does not allow you to issue an Alert." error.

All checks for $alert=='No' which are sprinkled all over the code are susceptible to this, too.
Part of the problem is an initial extremely bad database design decision - instead of using integer for a flag type db fields (alert, ban, etc), these fields are strings, and defaults to NULL, so in fact they could be in the 3 states: "Yes", "No" and NULL (or empty). This causes many problems and greatly encumbers the code as checks for empty values should be added everywhere.

sv1cec · #18 06-07-2005, 07:35 AM

kmike · #19 06-07-2005, 08:02 AM

sv1cec · #20 06-07-2005, 08:04 AM

Yes, it would, but I need time to change the code. I wanted to bring out a release which would fix the errors the users encountered. I plan to do a code-maintenance release in the next few days, where several areas of the code will be improved. If you have any other comments, I would appreciate if you could let me know.

Rgds

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04858 seconds Memory Usage 2,302KB Queries Executed 27 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)modsystem_post (1)navbar (6)navbar_link (120)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (10)post_thanks_box (10)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (10)post_thanks_postbit_info (9)postbit (1)postbit_attachment (10)postbit_onlinestatus (10)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_attachment postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!