search.php - help needed - "getdaily"

[amykhar]

For one thing, your equation is wrong. If you were trying to find posts from 2 days and 3 hours ago, which is possible to do, you would end up with
2*3*60*60, which isn't right.

What you need to do is to say that if hours, minutes, days, etc. aren't set, they are equal to 0.

Then, your math looks like (days *24*60*60) + (hours *60*60) + (minutes*60) + seconds.

[trevelyn1015]

so, amy, why does everything work fine, but minutes?

www.ranger-forums.com/forum2

[amykhar]

It won't work for seconds.

You got lucky with hours, because days is set to 1.

The equation for hours is TIMENOW - ($hours *60*60)

because there are 60 minutes in an hour and 60 seconds in a minute.

Anything bigger than an hour isn't a problem because your math holds true. The problem is with the minutes and seconds.

[trevelyn1015]

so what should i do, amy?

the original string of code for that section looked like this:

// #############################################################################
if ($_REQUEST['do'] == 'getnew' OR $_REQUEST['do'] == 'getdaily')
{
	globalize($_REQUEST, array(
		'forumid' => INT,
		'days' => INT,
		'exclude' => STR
	));

	// get date:
	if ($_REQUEST['do'] == 'getnew' AND $bbuserinfo['lastvisit'] != 0)
	{
		// if action = getnew and last visit date is set
		$datecut = $bbuserinfo['lastvisit'];
	}
	else
	{
		$_REQUEST['do'] = 'getdaily';
		if ($days < 1)
		{
			$days = 1;
		}
		$datecut = TIMENOW - (24 * 60 * 60 * $days);
	}

[sabret00the]

PHP Code:

     if ($_REQUEST['do'] == 'getnew' AND $bbuserinfo['lastvisit'] != 0)
     {
          // if action = getnew and last visit date is set
          $datecut = $bbuserinfo['lastvisit'];
     }
     else
     {
          $_REQUEST['do'] = 'getdaily';
          if ($days < 1)
          {
               $days = 1;
          }

          if (!$hours)
          {
               $hours = 0;
          }

          if (!$minutes)
          {
               $minutes = 0;
          }
          $datecut = TIMENOW - ($hours * $minutes * 0 * $days);
     } 


ok if i half understood what amy's saying, she's saying try that

[Dean C]

You can't default the variables to 0, that'll make it TIMENOW - 0 when you multiply anything by it.

[amykhar]

Originally Posted by Dean C

You can't default the variables to 0, that'll make it TIMENOW - 0 when you multiply anything by it.

Exactly, Dean. That's what you want to happen.

And, no Saber. That's not what I was saying My board is down right now so I can't test this, but I imagine it would look like this:

	else
	{
		$_REQUEST['do'] = 'getdaily';
		if (($days < 1)AND(!$hours)AND(!$minutes)AND(!$seconds))
		{
			$days = 1;
                        $hours = 0;
                         $minutes = 0;
                         $seconds = 0;
			
		}
		elseif($days < 1) {
                       $days = 0;
                }
		$datecut = TIMENOW - (($days*24*60*60) + ($hours*60*60) + ($minutes*60) + $seconds);
		
	}

Doing it this way doesn't mess up the original usage - if no variables are set, it should default to 1 day. If any combination of days, hours or minutes are set though, it should work.

Within that elseif block, you should check to see if the hours, minutes and seconds are properly set and initialize them to 0 if not.

[amykhar]

my site's back up, and it seems like it works as I posted it.

[trevelyn1015]

amykhar is my hero!!!

[sabret00the]

Originally Posted by amykhar

my site's back up, and it seems like it works as I posted it.

your smarts >>>>>>>>>>> mine