I'm having difficulty getting a Pop Up Window to work

[Ocean]

Hi!

I'm having some difficulty getting a link to open a Pop Up Window.

Here's what I'm using:

 
This is the Regular Link:
 
(<a href="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid">Execute Test Action</a>)
 
 
This is what I'm trying to modify it to, in order to get it to open in a Pop Up Window:
 
(<a href="#" onclick="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid; return false;">Execute Test Action</a>)
 
 

Obviously, I'm making a mistake. Can someone help me figure out what I'm doing wrong?


Thanks!

[Zachery]

Originally Posted by Ocean

Hi!

I'm having some difficulty getting a link to open a Pop Up Window.

Here's what I'm using:

 
This is the Regular Link:
 
(<a href="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid">Execute Test Action</a>)
 
 
This is what I'm trying to modify it to, in order to get it to open in a Pop Up Window:
 
(<a href="#" onclick="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid; return false;">Execute Test Action</a>)
 
 

Obviously, I'm making a mistake. Can someone help me figure out what I'm doing wrong?


Thanks!

Like a vB Menu popup, or a new window popup, do you need to control any aspects of the browser window, like heigh / size resiablity, disalbing anything else?

[Ocean]

Originally Posted by Zachery

Like a vB Menu popup, or a new window popup, do you need to control any aspects of the browser window, like heigh / size resiablity, disalbing anything else?

I'd like this to function similarly to the vBCode Pop Up, or the Who Posted Pop Up.

I don't really need to disable anything (except maybe the Status Bar - similar to how the Who Posted pop up does it), and I would like it to remain resizeable (if the user should drag out the lower right corner of the window).

[Ocean]

Zachery, does this mean that you know where I went wrong?

[Natch]

PHP Code:

<a href="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid" target="threadpop" onclick="window.open(this.href,this.target,width=400,height=400); return false;">Execute Test Action</a> 


Then you just adjust your width and height statement to match the contents of the popup, and it will degrade nicely if your users have javascript turned off...

You can also add other options after the width, height statements but still in the parenthesis to specifry which options you wanna turn on (status, resize, etc) - thje exact wording for these you can find on w3schools.com (I always rtfm, rather than using up precious memory space in my head with the exact wordings...)

[Ocean]

Originally Posted by Natch

PHP Code:

 
<a href="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid" target="threadpop" onclick="window.open(this.href,this.target,width=400,height=400); return false;">Execute Test Action</a> 


Then you just adjust your width and height statement to match the contents of the popup, and it will degrade nicely if your users have javascript turned off...

Natch, thank you for helping!

I have a few questions, though...


1. The syntax I originally tried, I have seen used before successfully. I recall its being recommended as it bypassed Javascript - and thus, wouldn't cause problems for people who had it turned off. If that's true, why didn't it work for me?

2. I tried your suggested syntax, and I have mixed results. The good news is that it does indeed open a Pop Up. The bad news is that the width and height settings seem to be ignored. Do they need to be specified differently?


Thanks again!

[Natch]

1] Your original code is

PHP Code:

<a href="#" onclick="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid; return false;">Execute Test Action</a> 


Should be

PHP Code:

<a href="#" target="windowname" onclick="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid; return false;">Execute Test Action</a> 


^^ That would work, but it's not really ideal as you have no control over the structure or "features" of the window...

2] OK: the structure of the window.open() function is as follows...

window.open(this.href,this.target,"toolbar=yes, location=yes, directories=no, status=no, menubar=yes, scrollbars=yes, resizable=no, copyhistory=yes, width=400, height=400")

There was an omitted set of Quotes in my code above around the final argument of the function...

The structure can be broken down into three arguments: link URI, window name (same as target), and features.

Link can be either a quoted URI (eg "forumdisplay.php?f=1342") or a legal DOM reference (aka this.href refers to the contents of the href statement in this a tag... ).

Window Name similarly can be either a quoted value for the window name (eg "_blank", "mypopup") or a legal DOM reference (aka this.target refers to the target field in this a tag... ).

This example above uses the extended version of the code for features, the only features that require a name=value structure are width and height, the others you only need to include a feature name if you wish it to be active.

So: your code should be

PHP Code:

<a href="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid" target="threadpop" onclick="window.open(this.href,this.target,'width=400,height=400,resize'); return false;">Execute Test Action</a> 


The reason this is a really ideal way of creating your popup links is that it will degrade well if users have JS turned off, in that a new window will still open, due to the target value being a real name, if it's blank, then it opens in this window...

Final Note:

A funky implementation or this is in the following example...

PHP Code:

<tr><td id="approach" class="row1" onmouseover="changeSty('row1hi',this.id)" onmouseout="changeSty('row1',this.id)" onclick="navCMPS(this.firstChild.href)"><a href="/somelink.php">a Linkage</a></td></tr> 


This is a part of a Navigation menu, and the two JS functions called are either changing the style onmouseover the Table Cell, or causing a link/popup to be called onclick of the Table Cell, without requiring much alteration for each new line... the opnly two changes reuquired are the link and name, and the link ID should be unique for each link...

HTH

[Ocean]

Originally Posted by Natch

The reason this is a really ideal way of creating your popup links is that it will degrade well if users have JS turned off, in that a new window will still open, due to the target value being a real name, if it's blank, then it opens in this window...

Your corrected code works perfectly. And I have taken your reasons for using this method to heart.

Thank you for your excellent help!

[Natch]

My pleasure: javascript is really your friend these days: so powerful in combination with PHP and a database...

[Ocean]

Originally Posted by Natch

My pleasure: javascript is really your friend these days: so powerful in combination with PHP and a database...

I guess I need to spend more time with this friend... <grin>