i dont understand

[Velocd]

The error I spotted:

PHP Code:

".iif($_POST['usejname']=='1', $nameformat)." 


$nameformat is a string, no? You are not providing the single quotes nor comma for it.

Here is a revamped and more readable version of your PHP:

PHP Code:

$nameformat = ",'".addslashes($jname)."'";
 
$DB_site->query_first("
    INSERT INTO ".TABLE_PREFIX."journals
        (journalist, journalist_id, journaldate,
        journaldesc, private, whocanview, lastentry,
        lastentry_date, ipaddress".($_POST['usejname'] ? ', journalname', '').") 
    VALUES 
        ('".addslashes($journalist)."', '".intval($journalistid)."', 
        ".TIMENOW.", '".addslashes($jdesc)."', '".$jpriv."', '".addslashes($whocanviewj)."', 
        '".addslashes($etitle)."', ".TIMENOW.", '".$REMOTE_ADDR."'".($_POST['usejname'] ? ", '$nameformat'", '')."
        )
"); 


I recommend to stick to this standard of formatting your queries. It's how vBulletin does it, and it just allows for easier visibility of spotting errors.

Other things I recommend:

• Don't quote numbers. e.g. $_POST['usejname'] == '1'. For the most cases when comparing if a value is 0 or 1, or if it has any value not zero, you can drop out the == operator and second operand and just use if($_POST['usejname']).
• Don't quote the TIMENOW constant. It returns a 10 integer unix timestamp, which again, is a number.
• Use the ternary operator (condition ? if_true_value: if_false_value) instead of the vBs iif(). If you ever go outside vBulletin coding, iif wont be available, so you should know ? and :
• $_POST['usejname'] looks a lot like $_POST['username'], maybe use underscores or something.. $_POST['use_jname'].