Small Calculation Glitch

[MooMan65]

Hey everyone. I ported over the calculation that was used often in vB2 to calculate Active/NonActive members and the Activity %, and I remember having problems with it before with the percentage displaying a massive negative number after months of working properly before. I just simply removed the hack and forgot about the glitch, but now that I'm using it again I've decided to ask here on advice to how to fix it.

Basically when the member count goes above 1000 the calculation screws up:

Total Registered Members: 1,000 (Active: -377, Inactive: 378) | Activity Rate: -37700.00 %

When before that it was working correctly.

Here is my PHP Code for the calculation of the stat:

PHP Code:

// calculate active and non active members from member stats
$snonposters=$DB_site->query_first('SELECT COUNT(*) AS users,MAX(userid) AS max FROM user WHERE posts=0');
$nonposters=$snonposters['users'];
$activemembers=$numbermembers-$nonposters;
$activityrate=sprintf("%.2f",(100*$activemembers/$numbermembers)); 


Any help would be greatly appreciated! Thanks!

[MooMan65]

Anyone? The stat is looking very weird currently.

[MooMan65]

Please? I'm lost here.

[Boofo]

Try this for the percentage:

PHP Code:

    if(activityrate > 100)
    {
        activityrate = vb_number_format(($activemembers / $numbermembers) * 100 / 1000, 2 ) . '%';
    }
    else
    {
        activityrate = vb_number_format(($activemembers / $numbermembers) * 100, 2) . '%';
    } 


[MooMan65]

Originally Posted by Boofo

Try this for the percentage:

PHP Code:

    if(activityrate > 100)
    {
        activityrate = vb_number_format(($activemembers / $numbermembers) * 100 / 1000, 2 ) . '%';
    }
    else
    {
        activityrate = vb_number_format(($activemembers / $numbermembers) * 100, 2) . '%';
    } 


Hmm. That gave the percentage a thousand comma (-37,700%) but didn't seem to solve anything.

The thing is I doubt the problem is in the percentage calculation. As you can see the Active Members number is screwed up, while the Inactive one isn't. Since the Active members calculation is TotalMembers - InactiveMembers it could be related to the Total Member variable.

Thing is though if I put $numbermembers ONLY it works right (displays 1000) while if I just put $nonposters it also works right (displays 378). BUT when you put them together in a calculation it treats the $numbermembers variable is only being 1. Not 1000. So 1-378 is -377 which is weird.

I've tried other random calculations and all the time it treats that variable as 1 and not 1000, but if I stick it there on it's own it displays 1000. This is just so totally random.

Anything else? Since $numbermembers is a normal variable on the forums, not one added by the hack it makes things worse... :-\

[Boofo]

Try doing the calculation with the following. This is what I use on my site.

vb_number_format(($numbermembers / $newuserid) * 100, 2 );

[MooMan65]

Originally Posted by Boofo

Try doing the calculation with the following. This is what I use on my site.

vb_number_format(($numbermembers / $newuserid) * 100, 2 );

Erm. That gives me a percentage of 0.09%.

PHP Code:

$activityrate=vb_number_format(($numbermembers / $newuserid) * 100, 2 ); 


And adjusting the variables to suit the hack ($activemembers / $numbermembers) gives me another weird number:

Total Registered Members: 1,062 (Active: 663, Inactive: 399) | Activity Rate: 66,300.00 %

Unless you were meaning something else in that post.

[Boofo]

How many members do you have? And what is the newest member's userid?

Here is the code I use in my forumhome stats hack on myy site and it works like it is supposed to:

PHP Code:

$statscache['activepercent'] = vb_number_format(($numbermembers / $newuserid) * 100, 2 ); 


Here are the rsults of that code:

Total Registrations: 51, Active Registrations: (47 Members = 92.16%)

[MooMan65]

Originally Posted by Boofo

How many members do you have? And what is the newest member's userid?

Here is the code I use in my forumhome stats hack on myy site and it works like it is supposed to:

PHP Code:

$statscache['activepercent'] = vb_number_format(($numbermembers / $newuserid) * 100, 2 ); 


Here are the rsults of that code:

Currently it's at 1062 members as the problem began when the members went above 1000. That normal code I posted in my first post worked fine up until 1000 members which just strikes me as strange.

The latest UserID is 1064, which just means that we've deleted 2 members since the beginning. To 1062/1064 I'm surprised gives you the correct answer.

Our users are only active if they've posted at least once. To the first line Queries the database getting the number of users with 0 posts. The second line assigns that number to $nonposters. Third line calculates the Active members by subtracting the Non Posters from the Total Members, then finally the last line calculates the Active User Percentage by dividing the Active Users into the Total Member Count. That makes sense, and it's worked, but when it reached 1000 members it screws up. As though it overflows the variable or something. I'm not sure.

But one thing I have done that's worked is sticking in the Member count manually into the calculations. Like instead of $numbermembers I put 1062 and it works fine, but the variable doesn't.

[Boofo]

Try using my calculation code all by itself, without your other code above it, and tell me if it is right then.