percentage code is way off on large boards

[John]

What does the $newuserid variable represent?

[John]

Either way - to figure out percentages, you divide the small number by the big number, and multiple by 100.

Looking at your code, I think you're doing it the other way round. (Presuming that $numbermembers is the total number, and $newuserid is the fraction of that.) If $newuserid is the bigger number, ignore the variable switch I made in the vb_number_format function below.

I've also removed the if statement, as I can't see what the difference is between the code in each branch.

PHP Code:


// this gives us a value in the $statscache['activepercent'] variable
$statscache['activepercent'] = vb_number_format(($newuserid / $numbermembers) * 100, 2 ); 

// You can lob off the last two digits: 
$lasttwo = substr($statscache['activepercent'], -2); 

// And then see if that equals 00 
if ($lasttwo == '00') 
{ 
     // intval returns an integer value 
     $statscache['activepercent']= intval($statscache['activepercent']); 
} 

// if you want it in the variable, we can add the trailing % from before
$statscache['activepercent'] .= '%'; 


[John]

Also, instead of $newuserid, shouldn't it be $activemembers?

[Boofo]

Originally Posted by John

Also, instead of $newuserid, shouldn't it be $activemembers?

When I used $activemembers like you suggested, it returned a 0. The $newuserid is the userid of the newest member, which would give you the highest number.

I used this same code at one time and it seems that any boards that have over 1000 posts mess up with the percentage like this. It ends up showing like 15,300%. What would cause this to be happening? On my small site I don't have that problem. It works great for me.

[John]

What do you get with $numbermembers / $newuserid?

[Boofo]

I get this:

Total Registrations: 46, Active Registrations: (42 Members = 91.30%)

That shows up fine but the problem I am having is with the Top Poster Percentage and the Top Thread Starter Percentage on larger boards. On mine, it works like it is suppposed to. On larger boards with large post counts and thread counts it really messes up. Check out my Forumhome Stats hack thread on the last 2 or 3 pages and you will see what I mean. Or even the first post in this thread.