Unnecessary query?

[Xenon]

@Bob: in the can_moderate function in functions.php

good thing, i used my selfwritten ismod() function for such things which remained from vb2 times ^^

[Boofo]

In place of this? Or is there some more?

PHP Code:

  else
  { // imodcache is not set - do a query
   DEVDEBUG('QUERY: is the user a moderator (any forum)?');
   $ismod_all = $DB_site->query("SELECT moderatorid, permissions FROM " . TABLE_PREFIX . "moderator WHERE userid = $userid");
   while ($ismod = $DB_site->fetch_array($ismod_all))
   {
    if ($do)
    {
     if ($ismod['permissions'] & $_BITFIELD['moderatorpermissions']["$do"])
     {
      return 1;
     }
    }
    else
    {
     return 1;
    }
   }
   return 0;
  } 


[Xenon]

correct just that one

[Boofo]

Thank you, sir.

[Natch]

Thanks for the clarification

[KuraFire]

I reported this bug back in beta 5 or so already, and then they just told me "you shouldn't use can_moderate() in a postbit" :|