Pickpocket in Lesane Store

As promised It's new version of steal addon to the Lesane Store.
At last the crime on my board is under control.
I translated all templates, but It's not the best english version.
Hope the instruction is full and understandable.
Have a fun.

[Roxie]

hmmm. I meant just for certain people to stop using him.Does buying insurance REPLACE him.

[GenSec]

Originally posted by vdinh
Hi GenSec,
One of my users actually uses the Back button to keep stealing until he is successful ... I already set up so that if a user's money is negative, he won't be allowed to steal. However, once this user was caught and his money was below 0, he keeps hitting the Back button to go back to steal and was able to do so ...

Is there a way to stop this? Thanks

It should to help:

PHP Code:

// ###################### Start Verify Stealing #######################
if ($action=="stealverify") {
$getrobber=$DB_site->query_first("SELECT storep FROM user WHERE userid='$bbuserinfo[userid]'");
If ($getrobber[storep]<0) {
    eval("standarderror(\"".gettemplate('store_steal_cannot')."\");");
}
$getduser=$DB_site->query_first("SELECT userid,usertitle,username,storep FROM user WHERE username='".addslashes(htmlspecialchars($stealusername))."'");
$contest = $DB_site->query_first("SELECT * FROM store WHERE action='steal'");
$storeid=$contest[id]; 


[GenSec]

Originally posted by Roxie
hmmm. I meant just for certain people to stop using him.Does buying insurance REPLACE him.

Yes. User need to chose between insurance and mafia.

[Stealthy]

GenSec, first of all, thank you for your great support for a great hack! My members really enjoy it.

I have a question: Is there a way to limit the number of times a user can attempt to steal in a given day?

Say, I want my members to only be able to attempt to steal twice in a 24 hr period. Is there a way to put this limit in?

[dadymac]

you really need to add http refers so that people dont just stick names in the code and have scripts where users will automatically try to steal.

[Apok2002]

As per Gensec, I used the following line (copy/paste) to make it so that people can't steal from Insurance or Godfather (it's ok to steal from admins though). I replaced his original line that he posted:

PHP Code:

if ($getduser[usergroupid]=="6" OR $getduser[userid]==$bbuserinfo[userid] OR $getduser[userid]=="GODFATHERid" OR $getduser[userid]=="INSURANCEid") { 


With the ID #'s of the Godfather and Insurance. Here is the whole code.

PHP Code:

if  $getduser[userid]==$bbuserinfo[userid] OR $getduser[userid]=="370" OR $getduser[userid]=="369") {
    eval("standarderror(\"".gettemplate('store_nosteal')."\");");
    } 


370 = Godfatherid, and 239 = Insuranceid. I created a new template called "store_nosteal" that simplay says you can't steal from the Godfather or Insurance.

I get the following error:
Parse error: parse error, unexpected T_VARIABLE, expecting '(' in /home/apok/public_html/forums/store.php on line 1074

What am I doing wrong? What is the fix?

[Apok2002]

Also, Gensec, as per your instructions on how to make it so that members MUST have at least $5 to steal, I copied/pasted your code, but it didn't work EXACTLY the way it's supposed to. Here is my code:

PHP Code:

if ($bbuserinfo[posts]<100 AND $bbuserinfo[storep]>5) {   // don't allow new  users to steal  -- Thief should have 100 posts
    eval("standarderror(\"".gettemplate('store_steal_cannot')."\");");
} 


If you have a negative balance it won't let you steal. But if you have $0 or more $$$, you CAN steal. Granted, it's just a few $$$ difference from $-1 to $5, but I'm just curious why it wouldn't work? It'd be nice to be able to control it...like making it be that even thiefs have to have $100 in the positive before they can steal. But it doesn't appear to work that way. It will only prevent theft if they are in the negative balance.

[Apok2002]

In the following code to prevent people from using the back button to steal:

PHP Code:

// ################ to prevent repeated attempts #################
if ($action=="stealverify") {
$getrobber=$DB_site->query_first("SELECT storep FROM user WHERE userid='$bbuserinfo[userid]'");
If ($getrobber[storep]<0) {
    eval("standarderror(\"".gettemplate('store_steal_cannot')."\");");
}
$getduser=$DB_site->query_first("SELECT userid,usertitle,username,storep FROM user WHERE username='".addslashes(htmlspecialchars($stealusername))."'");
$contest = $DB_site->query_first("SELECT * FROM store WHERE action='steal'");
$storeid=$contest[id]; 


There is NO change for me when I use this code above, as opposed the the original code of:

PHP Code:

if ($action=="stealverify") {
$getduser=$DB_site->query_first("SELECT userid,usertitle,username,storep FROM user WHERE username='".addslashes(htmlspecialchars($stealusername))."'");
$contest = $DB_site->query_first("SELECT * FROM store WHERE action='steal'");
$storeid=$contest[id]; 


Can you help?

[GenSec]

You forgot ( after if

PHP Code:

if  ($getduser[userid]==$bbuserinfo[userid] OR $getduser[userid]=="370" OR $getduser[userid]=="369") { 


Sec.
Should be

PHP Code:

if ($bbuserinfo[posts]<100 AND $bbuserinfo[storep]<5) 


In your case members MUST have at least 100 posts and less than $5.

[Apok2002]

Thanks for your help Gensec...my members are getting ancy about me going "live" w/ this hack. I still have a few things I wanna tweak first.

In your case members MUST have at least 100 posts and less than $5.

I used both OR and AND...and both allowed me to steal as long as I had $0 or more. No biggie though.

I'm more concerned w/ the "back button" bug that I listed above. Also, how do I put in html referrers so members aren't FORCED to use the back button to get back to the store, main page, or wherever they want to go. As of now...they have to use the back button which promotes the "bug" of redoing the steal over and over again.

Also, did you know that when they are penalized...they can still get around not being able to post...by simply using the Quick Reply box? Is there a code we can use to prevent them from using the Quick Reply box if they are being penalized (negative balance)?