Excessive Smilies overloading Servers

[Xenon]

hmm, but i think you cannot do anything against.

as i said before the str_replace function is executet just 20times/post
but if someone uses the same smilie 1000 times or more often it's the str_replace function which increases the server-time.
so i'd say the problem is php not vb

[Sparkz]

I have confirmed this myself too... I basicly put 10000 bytes of smiles (ie 5000 smilies) into a new post... It loads for a while and then it just stops loading. Nothing happens...

I even tried letting PHP use up to 75MB of ram, and 120 max execution time.

[Sparkz]

This board handled it easily, though...
https://vborg.vbsupport.ru/showthrea...threadid=41507

That post WILL most likely bog your browser down for a little while...

[Scott MacVicar]

Yeah it took a whole 4 seconds to load

[Logician]

Here is a fix for you:

edit function.php, find:

PHP Code:

 $bbcode=str_replace(trim($smilie[smilietext]),"<img src=\"$smilie[smiliepath]\" border=\"0\" alt=\"\">",$bbcode); 


Before that add:

PHP Code:

if (substr_count($bbcode, trim($smilie[smilietext]))>1000) 
{
// do something bad to the spammer like automatically changing his usergroup to banned members
// notify admin about his malicious behaviour etc.
// then exit in peace.. ;-)
exit;
} 


You can change 1000 with any numbers your server can handle.. This code will first count the smilie number in the post before attempting to process (replace) them and if the number is too high, it will exit and not let str_replace to run to get the server on its knees. FYI "substr_count" works VERY FAST so you dont need to worry about its performance..

BTW congratulate your "bored" members for me, it was a good catch..

Enjoy..
Logician

[JJR512]

Using Logician's idea, here's what I used:

PHP Code:

if (substr_count($bbcode, trim($smilie[smilietext]))>50) {
  eval("standarderror(\"".gettemplate("error_toomanyimages")."\");");
  exit;
} 


I didn't want to automatically ban the member or anything, in case it was an honest mistake. And I only used 50, because I have a low max image setting, anyway.

[Xenon]

normally then you should use that:

PHP Code:

if (substr_count($bbcode, trim($smilie[smilietext]))>$maximages) {
  eval("standarderror(\"".gettemplate("error_toomanyimages")."\");");
  exit;
} 


good idea logician

[Kaelon]

Thanks, Logician!

Only problem - I tried using

PHP Code:

if (substr_count($bbcode, trim($smilie[smilietext]))>$maximages) {
          eval("standarderror(\"".gettemplate("error_toomanyimages")."\");");
        exit;
} 


But even if I inserted one smiley, the error_toomanyimages template would be displayed. When I hardcoded "10" instead of $maximages, everything seemed to work fine.

Thanks again, gang.

Kaelon

[Xenon]

oh sorry that was my fault

a few lines above you find this code:

PHP Code:

global $DB_site,$wordwrap,$allowdynimg, $bbuserinfo; 


replace it with

PHP Code:

global $DB_site,$wordwrap,$allowdynimg, $bbuserinfo,$maximages; 


[Danny]

Originally posted by Logician
Here is a fix for you:

edit function.php, find:

PHP Code:

 $bbcode=str_replace(trim($smilie[smilietext]),"<img src=\"$smilie[smiliepath]\" border=\"0\" alt=\"\">",$bbcode); 


Before that add:

PHP Code:

if (substr_count($bbcode, trim($smilie[smilietext]))>1000) 
{
// do something bad to the spammer like automatically changing his usergroup to banned members
// notify admin about his malicious behaviour etc.
// then exit in peace.. ;-)
exit;
} 


where exactly am i looking for this? cause there is no function.php file only admin/functions.php and its not in that file.

i am using vb 2.2.6 btw.