Anyone notice about PMs?

[Takara]

There are a fiew things wrong with Private Messages.

#1, if you have no messages in any of your folders (recieved or sent) you see this:

<nick> - You have new message(s) since your last visit.
(You have unread messages and 0 total messages in all your folders.)

It SHOULD say 'You have 0 new messages' and 'You have 0 unread messages'. Aswell you can send a message to a user with just spaces in the subject, thats really annoying.

[Xenon]

open private.php
find:

PHP Code:

if ($message=="" or $touser=="" or $title=="") {
    eval("standarderror(\"".gettemplate("error_requiredfields")."\");");
    exit;
  } 


replace with

PHP Code:

if (trim($message)=="" or $touser=="" or trim($title)=="") {
    eval("standarderror(\"".gettemplate("error_requiredfields")."\");");
    exit;
  } 


then no " " messages could be sent anymore

[Takara]

Cool, thanks ^^

Now I just have to fix that other one.

[Takara]

Ah, its because I commented out the following queries in index.php

PHP Code:

  $allpm=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] $ignoreusers"); 
  $newpm=$DB_site->query_ffirst("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] AND dateline>$bbuserinfo[lastvisit] AND folderid=0 $ignoreusers");
  $unreadpm=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] AND messageread=0 AND folderid=0 $ignoreusers");

    $newpm['messages']=$allpm['newpm'];
    $unreadpm['messages']=$allpm['unreadpm']; 


and replaced by

PHP Code:

$allpm=$DB_site->query_first("SELECT COUNT(*) AS messages,
                                SUM(IF(dateline>$bbuserinfo[lastvisit] AND folderid=0,1,0)) AS newpm,
                                SUM(IF(messageread=0 AND folderid=0,1,0)) AS unreadpm
                                FROM privatemessage WHERE userid=$bbuserinfo[userid] $ignoreusers");

    $newpm['messages']=$allpm['newpm'];
    $unreadpm['messages']=$allpm['unreadpm']; 


I'll changed the end part to

PHP Code:

  if ($allpm['newpm'] == "") { 
    $newpm['messages']="0";
  } else {
    $newpm['messages']=$allpm['newpm'];
  }

  if ($allpm['unreadpm'] == "") { 
    $unreadpm['messages']="0";
  } else {
    $unreadpm['messages']=$allpm['unreadpm'];
  } 


But it hasnt worked yet. I'll keep playing.