Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #11  
Old 02-25-2017, 10:02 PM
tommythejoat's Avatar
tommythejoat tommythejoat is offline
 
Join Date: Apr 2008
Location: Boston
Posts: 155
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by MarkFL View Post
All I can tell you for sure is that with that code in place, when a reply is made without replying to or quoting a specific post, then the "parentid" for that post will be set to zero.
Actually, the fix needed a slight tweak on our Message Board. Apparently the 'p' index does not test false unless you use isset to test it.

I was a bit confused when it did not work on the first try, but I decided it could not possibly harm to make it.
PHP Code:
if (!isset($_REQUEST['p'])) {
$this->post['parentid'] = 0;

The only effect except eliminating the thread reference (that we find troubling) is that in hybrid or threaded view, the link graphics show a broken line for each new reference to the thread. It seems to me that is a benefit rather than a problem.

--------------- Added [DATE]1488068167[/DATE] at [TIME]1488068167[/TIME] ---------------

I do not think it is possible to make this "feature" retroactive.

In my opinion, the current vB4 behavior is broken. Clearly the reply to thread should set previous post to the starting thread post . There is no way to know what the poster intended or which button was used to create a new post since both point to the most recent post.

This fix does eliminate the problem. If one wanted the feature to actually reference the first post in the thread, that could be done or, retroactively in the future a query could be executed to set all the 0 parent postid values to the value of the first postid in the thread.

--------------- Added [DATE]1488080917[/DATE] at [TIME]1488080917[/TIME] ---------------

I thought I had this fixed but when I went to install it on the live site, it did not actually work and when I checked again on the test site the result was the same.

I hacked the plugin to insert a print_r on the $_REQUEST global and got this result for both reply from the border and reply with the button.

PHP Code:
capture vBulletin $_REQUEST for post thread at postdata_presave hook

Array ([do] => postreply [t] => 139871 [message_backup] => one more [message] => one more 
[wysiwyg] => [signature] => [fromquickreply] => [s] => [securitytoken] => nnnnnnnnn
[p] => 1087469 [specifiedpost] => [parseurl] => [loggedinuser] => [posthash] => nnnnnnnnn
[poststarttime] => 1488076181 [ajaxqrfailed] => [threadid] => 139871 [postid] => 1087469 [styleid] => 
[
langid] => [api] => [refererid] => [a] => [nojs] => [forumid] => [pollid] => [dofbredirect] => 
[
pagenumber] => [noquote]=>) [quoteall] =>) 
'p' and 'postid' are both set to the same value and not missing or 0, etc.

Is there a different hook that will work, or is one of my other mods busting this. I notice that there is a jquery flag that looks like it may be bad.
Reply With Quote
Благодарность от:
MarkFL
  #12  
Old 04-29-2017, 05:28 PM
chloe101 chloe101 is offline
 
Join Date: Dec 2007
Posts: 116
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Have you found a fix for this yet? I'm running VB4.2.4 and just noticed the same exacerbating problem. I'm trying to find a fix for this and if not, I'll just remove that button because it's misleading & useless as is.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 12:05 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03775 seconds
  • Memory Usage 2,189KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (2)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (2)post_thanks_box
  • (1)post_thanks_box_bit
  • (2)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (2)post_thanks_postbit_info
  • (2)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete