Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 02-24-2017, 06:15 PM
tommythejoat's Avatar
tommythejoat tommythejoat is offline
 
Join Date: Apr 2008
Location: Boston
Posts: 155
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Is the vB4 thread structure broken

The two methods to reply in a thread are to reply to the post you are viewing using the reply link in the bottom border or to reply to the thread.

The reply to specific post works correctly and puts that postid in the parent postid for the new post. However, when you are replying to the thread, the parent postid is the latest post in the thread when it should be the first post in the thread.

The problem is readily visible when using hybrid or threaded view.

I would like for the parent postid to be 0 just as it is for the starting post in the thread. That gives a distinctive display for hybrid and threaded views.

We have a mod installed that appends a link in the title of the posters name linking to the parent postid. If the parent postid were 0 for reply to thread, the link would be suppressed and it would work the way we want it to.

The reference functions to prevent misunderstandings when someone thinks a reply is to their post instead of to a previous post in the thread or the thread as a whole.
Reply With Quote
Благодарность от:
chloe101
  #2  
Old 02-24-2017, 06:58 PM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Try this plugin, hooked at "postdata_presave":

PHP Code:
if (!$_REQUEST['p'])
{
    
$this->post['parentid'] = 0;

Reply With Quote
  #3  
Old 02-24-2017, 09:50 PM
Bill Stuntz Bill Stuntz is offline
 
Join Date: Feb 2015
Location: Columbus, OH
Posts: 55
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
If it set the parentid to 0 instead of the incorrect postid that it picks now when invoked by "Reply to Thread" it shouldn't display ANY link in that new post title - which is what I want.
I asked the SAME question a couple days ago in another thread, https://vborg.vbsupport.ru/showthread.php?t=324497, trying to find SOME hook somewhere that would allow me to do EXACTLY that. We described different symptoms of the same disease, caused by the same germ. Tom & I are Admins on the same MB. Needless to say, HE's the senior admin, and I'm trying to learn.

I'm curious. Why did Tom get an essentially immediate response that does EXACTLY what I've been asking for, and my thread didn't? Have I done something to offend someone?
Reply With Quote
  #4  
Old 02-24-2017, 09:57 PM
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Location: Nottingham, UK
Posts: 23,748
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Replies can sometimes be days.
Any response is entirely dependent on who is reading the forums at any given time
Your thread got a reply after 81 minutes, so I think you have nothing to be curious about.
Reply With Quote
Благодарность от:
CAG CheechDogg
  #5  
Old 02-24-2017, 10:14 PM
Bill Stuntz Bill Stuntz is offline
 
Join Date: Feb 2015
Location: Columbus, OH
Posts: 55
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yes, you DID respond that fast. And your response allowed me to find the apparently undocumented plugin that gave me the hint that I had to modify parentid. But I couldn't figure out where/how to do that. MarkFL's response does exactly what I've spent days trying to figure out. It wasn't so much the SPEED of the responses that bothered me. Is MarkFL the only one who knows that trick?

It should solve the problem for future posts, but I doubt that there's any way to fix the existing misleading links.
Reply With Quote
  #6  
Old 02-24-2017, 10:15 PM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Bill Stuntz View Post
I asked the SAME question a couple days ago in another thread, https://vborg.vbsupport.ru/showthread.php?t=324497, trying to find SOME hook somewhere that would allow me to do EXACTLY that. We described different symptoms of the same disease, caused by the same germ. Tom & I are Admins on the same MB. Needless to say, HE's the senior admin, and I'm trying to learn.

I'm curious. Why did Tom get an essentially immediate response that does EXACTLY what I've been asking for, and my thread didn't? Have I done something to offend someone?
Hey Bill,

I do apologize if I gave the impression of preferential treatment...it wasn't my intention. Tom's initial post spoke explicitly of setting the "parentid" of posts made by replying to threads as opposed to replying to posts or quoting posts.

In your thread, you were talking about using a product that wasn't behaving as you wanted, and when I read that, I felt looking for the product thread was a good idea as suggested. Sometimes I don't connect the dots as would be desired by the person posting.

It could be the case when I read a post here, I am either idle and looking for something to do, or I am busy at the moment with other things and don't give the post as much attention as I would in the first scenario. That's my shortcoming, not that of anyone else, and is something I should try to improve.
Reply With Quote
Благодарность от:
CAG CheechDogg
  #7  
Old 02-24-2017, 10:22 PM
Bill Stuntz Bill Stuntz is offline
 
Join Date: Feb 2015
Location: Columbus, OH
Posts: 55
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks Mark. It was the stuff I found, guided by Paul's post, that allowed Tom to ask the question in the way he did. THANK YOU BOTH for the help!!!!!!!!!!!!!

P.S. I think I made the same point over there, too:
Quote:
It works properly when replying to a specific post by using the correct non-zero parentid, but "Reply to Thread" seems to pick an inappropriate parentid.
P.P.S. I intend to install the "editor button" mod you did for me after things settle down & we get on the new system.

--------------- Added [DATE]1487982823[/DATE] at [TIME]1487982823[/TIME] ---------------

Tom, are you going to install the fix, or are you going to leave it as an exercise for the student?
Reply With Quote
  #8  
Old 02-24-2017, 10:38 PM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Bill Stuntz View Post
Thanks Mark. It was the stuff I found, guided by Paul's post, that allowed Tom to ask the question in the way he did. THANK YOU BOTH for the help!!!!!!!!!!!!!

P.S. I think I made the same point over there, too:
P.P.S. I intend to install the "editor button" mod you did for me after things settle down & we get on the new system.
Yeah, that was part of me not connecting the dots when you posted. I believe also when you posted, I was hip deep in coding a custom mod for MHB (which turned out quite well!) and my mind was elsewhere. I'm not a good multi-tasker.

By the way, and I say this not to be self-effacing, but you asked if I was the only one who knew that trick. Of all those on staff here, and many who aren't on staff, I am the new guy still learning the basics.

I hope the custom editor toolbar mod works well for you! :up:
Reply With Quote
  #9  
Old 02-25-2017, 12:03 AM
Snowhog's Avatar
Snowhog Snowhog is offline
 
Join Date: Oct 2011
Location: Andover, MN
Posts: 423
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by MarkFL View Post
Try this plugin, hooked at "postdata_presave":

PHP Code:
if (!$_REQUEST['p'])
{
    
$this->post['parentid'] = 0;

I don't want to assume, so will adding this have any effect if using the default Linear Mode?
Reply With Quote
  #10  
Old 02-25-2017, 12:09 AM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Snowhog View Post
I don't want to assume, so will adding this have any effect if using the default Linear Mode?
All I can tell you for sure is that with that code in place, when a reply is made without replying to or quoting a specific post, then the "parentid" for that post will be set to zero.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 07:55 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04954 seconds
  • Memory Usage 2,280KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (2)bbcode_php
  • (6)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (10)post_thanks_box
  • (3)post_thanks_box_bit
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (3)post_thanks_postbit
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete