Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #11  
Old 06-07-2016, 05:07 PM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Stratis View Post
I thought that you see something else...
Now that you mentioned I see the tooltip, something that in all tests my eyes did not fall on, because I was watching editor with the post and the Required field. I will write in the phrase "Required" and the tooltips phrases.
Hope this will be ok, and not users keep trying to save it.

Thank you for your support helping me.
I made some improvements, among these is the ability to set a minimum character count for the edit reason field.
Attached Files
File Type: xml product-markflrequireeditreason.xml (10.2 KB, 2 views)
Reply With Quote
  #12  
Old 06-08-2016, 02:37 AM
Stratis's Avatar
Stratis Stratis is offline
 
Join Date: Jan 2010
Posts: 738
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

At least now they wont put dots or comma,

I will write the "minimum characters allowed" in description to, this is a little issue
but makes what i want. Thanks a lot for another time
Reply With Quote
  #13  
Old 06-08-2016, 03:57 AM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

In the next update, I will include the minimum characters in the field description as well, and I am thinking to give you the option to define a list of acceptable reasons from which the user can choose from a drop-down menu (as well as use their own).
Reply With Quote
Благодарность от:
Stratis
  #14  
Old 06-08-2016, 04:51 PM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Okay Stratis,

I have attached the update containing the additional features I mentioned above.
Attached Files
File Type: xml product-markflrequireeditreason.xml (12.6 KB, 3 views)
Reply With Quote
  #15  
Old 06-08-2016, 06:56 PM
Stratis's Avatar
Stratis Stratis is offline
 
Join Date: Jan 2010
Posts: 738
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Very clever Mark, Clever things by clever man

The only is a tiny issue with google chrome and "MarkFL - Remove Post Edit History" Modification.

* When I remove as administrator the edit history, and member goes to edit his post and than select "suggested reasons" or write in reason field "Save" button does not take effect. If user press "Cancel' and again edit, than is no problem as described above, or If browser refreshed works well.

This happens only if History is cleared, if its not there is no issue.

With IE11, Edge and Firefox no problem in all situations.
This is only info for you, so you don't say that I am not a good tester.

Special thanks Mark

If finally publish it and you want, have in mind the time we have in standard vb options (after how many minutes/hours will show edited post by user)
Reply With Quote
  #16  
Old 06-09-2016, 01:00 AM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I have attached an update, which now shows an alert on the quick edit form just like it does on the advanced edit form.

Quote:
Originally Posted by Stratis View Post
Very clever Mark, Clever things by clever man

The only is a tiny issue with google chrome and "MarkFL - Remove Post Edit History" Modification.

* When I remove as administrator the edit history, and member goes to edit his post and than select "suggested reasons" or write in reason field "Save" button does not take effect. If user press "Cancel' and again edit, than is no problem as described above, or If browser refreshed works well.

This happens only if History is cleared, if its not there is no issue.

With IE11, Edge and Firefox no problem in all situations.
This is only info for you, so you don't say that I am not a good tester.
I tested this in the updated version, and it seems to work correctly in Chrome (at least for me).

I would never say you are not a good tester...except perhaps to say you are an excellent tester.

Quote:
Originally Posted by Stratis View Post
Special thanks Mark

If finally publish it and you want, have in mind the time we have in standard vb options (after how many minutes/hours will show edited post by user)
That is an excellent suggestion to incorporate the intrinsic vBulletin permissions...so in addition to the usergroups you select to be exempt from giving an edit reason, usergroups who have "Show edited by note on edited messages?" set to "No" in the "General Permissions" section of the Usergroup Manager" will also be exempt, since requiring a reason would defeat that setting.

Also, anyone editing a post within the time limit defined in the setting "Time to Wait Before Starting to Display 'Last Edited by...'" under "Message Posting and Editing Options" will also be exempt.

So, if you don't mind Stratis, give this update a run through and let me know what you think.
Attached Files
File Type: xml product-markflrequireeditreason.xml (13.7 KB, 3 views)
Reply With Quote
  #17  
Old 06-09-2016, 02:32 AM
Stratis's Avatar
Stratis Stratis is offline
 
Join Date: Jan 2010
Posts: 738
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

It is better now, the only thing is "Minimum Characters" does not work.
Reply With Quote
  #18  
Old 06-09-2016, 02:40 AM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Stratis View Post
It is better now, the only thing is "Minimum Characters" does not work.
How so? Everything checks out for me...
Reply With Quote
  #19  
Old 06-09-2016, 03:01 AM
Stratis's Avatar
Stratis Stratis is offline
 
Join Date: Jan 2010
Posts: 738
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

For me it is not ok.

Before show you some images, the previous worked and works, tested again, uninstalled the new and installed the previous, i did this 4 times to check the new xml with clean install.

Here is the limit
Attachment 155113

As you see in 4 characters i have
Attachment 155111

Saved after...
Attachment 155112

Here is with the previous xml, works fine.
Attachment 155114
Reply With Quote
  #20  
Old 06-09-2016, 03:08 AM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

In the image where you have "test" entered in the field, it says "Optional"...this could be because you are likely exempt due to editing before the time limit is up and/or because of your usergroup permissions...perhaps?
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 01:15 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04573 seconds
  • Memory Usage 2,289KB
  • Queries Executed 14 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (4)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (10)post_thanks_box
  • (1)post_thanks_box_bit
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (3)postbit_attachment
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_attachment
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete