Infraction Hook

[Chris.08i]

Hello,

It's me again - I was wondering if anyone could tell me which hook to latch my plugin onto if I wanted to modify a column within the users table.

I have tried the hooks 'infractiondata_postsave, infractiondata_presave, and memberinfraction_complete".

Either I have the wrong hook, or something in my code is wrong (which is probably the case)

PHP Code:

<?php
global $vbulletin, $prepared;
$usersid = $prepared['userid'];

$ipoints = $vbulletin->db->query_first("
    SELECT COUNT(*)
    FROM " . TABLE_PREFIX . "user.ipoints
    WHERE userid = " . $usersid . " 
");

$imodpp = 150;
    
    if ($ipoints >= 1) {
        $imodpp = $imodpp * ($ipoints * 2.5);
    }
    
    if ($ipoints > 0) {
            $vbulletin->db->query_write("
            UPDATE " . TABLE_PREFIX . "user
            SET reputation = reputation - " . $imodpp . "
            WHERE userid = " . $usersid)
        );    
    }



?>

[MarkFL]

Okay, the first thing is, in a plugin you don't want to include the PHP tags. If your code is in an external file called by a plugin, then you do need the tags.

The hook location "infractiondata_postsave" is a good one (assuming you want this code to execute after the infraction is given), and you'll need to make the $userinfo array global to access it. This array will contain information regarding the user receiving the infraction.

You first query looks like it needs some tweaking, but please let me know exactly what you want to accomplish with this code, and I will try to point you in the right direction.

[Chris.08i]

Originally Posted by MarkFL

Okay, the first thing is, in a plugin you don't want to include the PHP tags. If your code is in an external file called by a plugin, then you do need the tags.

The hook location "infractiondata_postsave" is a good one (assuming you want this code to execute after the infraction is given), and you'll need to make the $userinfo array global to access it. This array will contain information regarding the user receiving the infraction.

You first query looks like it needs some tweaking, but please let me know exactly what you want to accomplish with this code, and I will try to point you in the right direction.

I want to deduct reputation points from the user that is receiving the infraction.

The base amount is 150 points, but each active infraction point (ipoints in users table as far as I know) will apply a 2.5x multiplier. For example, someone with 4 infraction points will receive 1500 points deduction from their reputation column.

I hope that makes sense.

[MarkFL]

Originally Posted by Chris.08i

I want to deduct reputation points from the user that is receiving the infraction.

The base amount is 150 points, but each active infraction point (ipoints in users table as far as I know) will apply a 2.5x multiplier. For example, someone with 4 infraction points will receive 1500 points deduction from their reputation column.

I hope that makes sense.

Yes, makes perfect sense. What we can do is get this done with just one query. While this code (hopefully) won't be called often, it's a good idea to get in the practice of minimizing the number of queries for any operation.

PHP Code:

global $userinfo;

$vbulletin->db->query_write("
UPDATE " . TABLE_PREFIX . "user
SET reputation = (reputation - (375*ipoints))
WHERE userid = " . $userinfo['userid']
); 


[Chris.08i]

Originally Posted by MarkFL

Yes, makes perfect sense. What we can do is get this done with just one query. While this code (hopefully) won't be called often, it's a good idea to get in the practice of minimizing the number of queries for any operation.

PHP Code:

global $userinfo;

$vbulletin->db->query_write("
UPDATE " . TABLE_PREFIX . "user
SET reputation = (reputation - (375*ipoints))
WHERE userid = " . $userinfo['userid']
); 


What if ipoints = 0?

I still want to deduct 150 from their reputation.

[MarkFL]

Originally Posted by Chris.08i

What if ipoints = 0?

I still want to deduct 150 from their reputation.

Your original code indicated that a deduction only occurs when ipoints > 0. But, if you want 150 rep deducted when ipoints = 0, and otherwise 375 * ipoints rep deducted then our code would be (since we don't have a nice linear relationship):

PHP Code:

global $userinfo;

$vbulletin->db->query_write("
    UPDATE " . TABLE_PREFIX . "user
    SET reputation = CASE ipoints
        WHEN 0 THEN (reputation - 150)
        ELSE (reputation - (375*ipoints))
    WHERE userid = " . $userinfo['userid']
); 


[Chris.08i]

Originally Posted by MarkFL

Your original code indicated that a deduction only occurs when ipoints > 0. But, if you want 150 rep deducted when ipoints = 0, and otherwise 375 * ipoints rep deducted then our code would be (since we don't have a nice linear relationship):

PHP Code:

global $userinfo;

$vbulletin->db->query_write("
    UPDATE " . TABLE_PREFIX . "user
    SET reputation = CASE ipoints
        WHEN 0 THEN (reputation - 150)
        ELSE (reputation - (375*ipoints))
    WHERE userid = " . $userinfo['userid']
); 


Well that sums it up nicely!

I was going to use if statements to create the effect I needed, turns out I don't need to!

Thanks so much for your help Mark, definitely learned a lot these couple days.

Edit: I just tried it - I'm getting a Server 500 error when I try infract someone. Any ideas?

Edit #2: So I globalised $vbulletin as well and it started running the code properly. However it isn't properly deducting from the table.

Edit #3: I got it to deduct!

It turns out we were missing an 'END' to the case which cause an MySQL syntax error.

However it now seems like it's going through both cases and deducting a total of 525 every time, no matter what! Not sure why the case rules aren't working!

Edit #4:
Okay - I got fed up so I ended up going with this. However, this code for some reason deducts double what I calculate it should do. For example, those with 0 ipoints, gets deducted 300 instead of 150, and those with 1 ipoint get deducted 750 instead of 375.

PHP Code:

global $userinfo, $vbulletin;

if ($userinfo['ipoints'] == 0) {
$base = 150;
$vbulletin->db->query_write("
    UPDATE " . TABLE_PREFIX . "user
    SET reputation = reputation - " . $base . "
    WHERE userid = " . $userinfo['userid']
);
}

if ($userinfo['ipoints'] > 0) {
$imodpp = 150 * ($userinfo['ipoints'] * 2.5);
$vbulletin->db->query_write("
    UPDATE " . TABLE_PREFIX . "user
    SET reputation = reputation - " . $imodpp . "
    WHERE userid = " . $userinfo['userid']
);
} 


I know this isn't the most efficient way - but it's the most working I could get it to so far!

[MarkFL]

This plugin works correctly on my local dev site:

Product: vBulletin

Hook Location: infractiondata_postsave

Title: Deduct Rep When Infracting

Execution Order: 5

Plugin PHP Code:

PHP Code:

global $vbulletin, $db, $userinfo;

$points = $userinfo['ipoints'];
$rep = $userinfo['reputation'];

if ($points > 0)
{
    $newrep = ($rep - $points*375);
}
else
{
    $newrep = ($rep - 150);
}

$vbulletin->db->query_write("
    UPDATE " . TABLE_PREFIX . "user
    SET reputation = " . $newrep . "
    WHERE userid = " . $userinfo['userid']
); 


Plugin is Active: Yes

[Chris.08i]

I had an adaptation of mine that I have been using for the past couple days that have been working for me.

I have changed over to your code as it's much neater! Thank you again Mark for your time and help!

I was wondering if it was possible to only trigger the above deduction when an actual point is issued, and no deduction for warnings?

[MarkFL]

Originally Posted by Chris.08i

I had an adaptation of mine that I have been using for the past couple days that have been working for me.

I have changed over to your code as it's much neater! Thank you again Mark for your time and help!

I was wondering if it was possible to only trigger the above deduction when an actual point is issued, and no deduction for warnings?

Do you mean then a deduction based only on the points being issued at the time, and not on the cumulative total of active points? If so, I would have to investigate to see how to retrieve that value.

The code I posted does exactly the opposite of that...it uses $userinfo['ipoints'] which does not include the points currently being given, but rather the number of points accumulated by the user before the current infraction.

edit: Try using the hook location "infraction_update_complete", and at that hook, the points for the current infraction is in $vbulletin->GPC['points']. Then you can base the rep deduction on that and update the user table.