Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #21  
Old 09-21-2014, 05:35 PM
AndrewSimm AndrewSimm is offline
 
Join Date: Sep 2006
Location: Atlanta, GA
Posts: 222
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

What does beta 2 fix over beta 1?

btw I run php 5.5.16 / PHP-FPM and Zend OpCache and they run great. I get much better performance than I did on 5.4 / PHP-FPM and APC. I am just waiting on cPanel to release PHP 5.6 before trying that.
Reply With Quote
  #22  
Old 09-21-2014, 06:11 PM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Disco_Stu View Post
What exactly are the compatibility issues between vBulletin 4.xx and PHP 5.4 & 5.5? Is it syntax, functions, etc??

The purpose of this release is to update the software to PHP 5.5.0 compliance by replacing the /e parameter in regular expressions with proper callback functions. vBulletin 4.2.3 Beta 1 also includes fixes for PHP 5.4.0 compliance along with several other minor bug fixes.
Reply With Quote
  #23  
Old 09-21-2014, 07:07 PM
Disco_Stu Disco_Stu is offline
 
Join Date: Apr 2012
Posts: 305
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
The purpose of this release is to update the software to PHP 5.5.0 compliance by replacing the /e parameter in regular expressions with proper callback functions. vBulletin 4.2.3 Beta 1 also includes fixes for PHP 5.4.0 compliance along with several other minor bug fixes.
So the main issue is with parameters on calls to PHP functions? Can you please provide an example?

I'm trying to determine the scope of these incompatibilities and if a few simple code changes can address them.
Reply With Quote
  #24  
Old 09-21-2014, 07:15 PM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

That would be a question you should as on vB.com, this site is not geared towards that type of thing.
Reply With Quote
  #25  
Old 09-21-2014, 07:25 PM
tbworld tbworld is offline
 
Join Date: Oct 2008
Posts: 2,126
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I use a simply file/text compare utility with a filter. Gets the job done nicely.
Reply With Quote
  #26  
Old 09-21-2014, 07:58 PM
Disco_Stu Disco_Stu is offline
 
Join Date: Apr 2012
Posts: 305
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
That would be a question you should as on vB.com, this site is not geared towards that type of thing.
I was just curious if this is a major issue or a minor issue. I was hoping to see a code example to see what the real issue is. Sometimes these things boil down to a few minor software changes.

If it's a mater of modifying call parms then I have no problem making the changes myself instead of applying an upgrade. I've modified so much of the original PHP files and templates that at least 1/3 of the code I use is not native vBulletin anymore.
Reply With Quote
  #27  
Old 09-21-2014, 08:47 PM
tbworld tbworld is offline
 
Join Date: Oct 2008
Posts: 2,126
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I was guessing that was the reason. I am not sure If if I have my filtered source files, but I will check. If I do, I will grab you some sample code changes. Sorry, I do not remember the bulk of changes .. it has been a while already.
Reply With Quote
  #28  
Old 09-21-2014, 10:29 PM
tbworld tbworld is offline
 
Join Date: Oct 2008
Posts: 2,126
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

So there are quite a few simple line edits, three to four hours of manual work while watching football if your not using folder/file text compare utility, less if you are using auto text replacement software. Two or less lines per file require changing on average.

I attached a list of the changed files. I doubt that I am allowed to post the actual text changes in all the files.

Attached Files
File Type: txt v422 to v423 file compare list.txt (4.0 KB, 24 views)
Reply With Quote
Благодарность от:
puertoblack2003
  #29  
Old 09-21-2014, 11:27 PM
Disco_Stu Disco_Stu is offline
 
Join Date: Apr 2012
Posts: 305
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by tbworld View Post
So there are quite a few simple line edits, three to four hours of manual work while watching football if your not using folder/file text compare utility, less if you are using auto text replacement software. Two or less lines per file require changing on average.

I attached a list of the changed files. I doubt that I am allowed to post the actual text changes in all the files.

I appreciate the file list but what I meant was a single line of code that is an issue due to the newer version of PHP. Like a call statement or function where the parameters are inconsistent with the new PHP versions.

For example:

Current PHP version FunctionX(parm1, parm2, parm3)

New PHP version FunctionX(parm1, parm2, parm3, parm4, parm5)


A piece of actual code that is a problem due to a newer version of PHP

In other words, not the number of files that need to be changed but what the changes actually are. I can scan the files for the code to change if I know what the required changes are
Reply With Quote
  #30  
Old 09-22-2014, 12:07 AM
tbworld tbworld is offline
 
Join Date: Oct 2008
Posts: 2,126
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I thought I knew what you were looking for so I second guessed you. I figured you wanted to know weather it was worth your expenditure of time at this point, which is why I opted to give you the results in the above format. Unfortunately, I do not have the time to look at most of the files to give you a generalization or search terms, but would be happy to present you with some differences if you want to select a few files from that list. Most of the changes or summation are already outlined on the PHP site, under migration. The vBulletin changes I noticed, followed the guideline. I have a complete filtered list, but it will be less time consuming for you to compare your source to the original and makes changes accordingly. Creating a side-by-side compare list can easily be accomplished with file/text compare software, as you know. The company I work for generates their own code utilities, but if you need references to commercial utilities then I can suggest a few. They are not for the novice, as having a good understanding of filtering techniques is a must -- as would be expected.

As long as your specific, I am happy to provide you with whatever I know.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 07:00 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05460 seconds
  • Memory Usage 2,276KB
  • Queries Executed 14 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (4)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (10)post_thanks_box
  • (1)post_thanks_box_bit
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (1)postbit_attachment
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_attachment
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete