Update to 4.2.2 blew up my board.

[Paul M]

I can turn ALL of my mods off and I still can't upload an attachment.

You should log a support ticket for that, I dont recall any particular changes to attachments.

[ozzy47]

Yeah, there is alot going on, thanks for understanding.

[meaters]

Paul, we all greatly appreciate your time and work but this upgrade really turned out more problematic that anyone had expected...errors popping everywhere after upgrade, templates broken.

[CarlitoBrigante]

Originally Posted by Paul M

There is no bug in the error handler.

Paul, do not be so dismissive, it is silly. 5 forum upgrades today, all with display errors set to off and errors still displaying. Anyhow, I said "I think" in my post. If the error is not in the error handler, could be elsewhere.

[ForceHSS]

Originally Posted by Paul M

You should log a support ticket for that, I dont recall any particular changes to attachments.

I get a error for attachments as well

[meaters]

Horrible

Vbulletin needs to release a fix for all these issues, this is no good

[CarlitoBrigante]

Originally Posted by CarlitoBrigante

Paul, do not be so dismissive, it is silly. 5 forum upgrades today, all with display errors set to off and errors still displaying. Anyhow, I said "I think" in my post. If the error is not in the error handler, could be elsewhere.

OK, since I am a stupid bastard, instead of working on my stuff I decided to jump into it, and it looks like I was right. The implementation of the error_handler in vBulletin 4.2.2 is wrong, or at the very least, incomplete.

The final part of the new error handler, the one matching all errors not matched by previous cases, which means also deprecated errors (those most people in the forums have been having problems with) contains this:

default:
      	if (error_reporting() OR ini_get('display_errors'))
      	{

and vBulletin then proceeds to echo the error.

This means errors will be shown if error_reporting is enabled even if display errors is set to off. A correct implementation of an error_handler needs to follow the configuration settings specified on the server and react accordingly.

More on this here:

http://stackoverflow.com/questions/5...700117#5700117

I do not have the time to submit this to vBulletin's JIRA, so if you guys have the time, do it. I will submit only a trouble ticket for this.

[ForceHSS]

So I put up a fresh install for testing and the problem with attachments they are still there was just making sure the problem was not with my forums. VB needs to fix this problem now some kind of quick fix in the next hour this should of been tested before it was given out

[CarlitoBrigante]

And for forum owners, a possible solution to this is just to change this in includes/class_core.php line 5733

      		if (error_reporting() OR ini_get('display_errors'))
      		{
      			if (defined('DIR'))
      			{
      				require_once(DIR . '/includes/functions_log_error.php');
      				$message = "Warning: $errstr in $errfile on line $errline";
      				log_vbulletin_error($message, 'php');
      			}

to this

      		if (error_reporting() OR ini_get('display_errors'))
      		{
      			if (defined('DIR'))
      			{
      				require_once(DIR . '/includes/functions_log_error.php');
      				$message = "Warning: $errstr in $errfile on line $errline";
      				log_vbulletin_error($message, 'php');
                                if(!ini_get('display_errors')) return;
      			}

This is a very rushed out solution, and I encourage you guys to double check it as I really really do not have the time (do not want to be mean, I just have been up in front of the monitor for 18 hours straight upgrading stuff already).

--------------- Added [DATE]1381371455[/DATE] at [TIME]1381371455[/TIME] ---------------

Guys, I can confirm I had a similar problem with attachments in a forum and it was, once again, caused by the issue I posted above about warnings coming out at the head of the AJAX response. Using the fix above and hiding the display errors made them work for me.

Not sure this covers also your cases (it does not seem to as some of you are reporting issues with fresh installs which should not contain deprecated messages), but just double check this is not what is causing the problem for you as well.

[meaters]

Originally Posted by ForceHSS

VB needs to fix this problem now some kind of quick fix in the next hour this should of been tested before it was given out

Shame really, never imagined we could come to this.