vbulletin_facebook.js patch ??

[karlm]

http://tracker.vbulletin.com/browse/...3Aall-tabpanel

On the tracker is a patch released earlier today - YAY!

What the hell am I supposed to do with it though?

Current instructions consist of:

Give the attached patch a try.

Having selected the patch, it opens a tab in firefox with the following code:

PHP Code:

Index: clientscript/vbulletin_facebook.js
===================================================================
--- clientscript/vbulletin_facebook.js    (revision 56167)
+++ clientscript/vbulletin_facebook.js    (working copy)
@@ -41,9 +41,7 @@
             [{id : "fb_loginbtn"}, {id : "fb_regloginbtn"}, {id : "fb_getconnected"}]
     };
 
-    // if auto-reg is enabled, we need to prompt
-    // for email permissions on first login
-    this.loginperms = this.get_config('autoreg') ? {perms:'email'} : {perms:'email,user_about_me,user_activities,user_birthday,user_interests,user_likes,user_website,user_location,user_work_history'};
+    this.loginscope = {scope:'email,user_about_me,user_activities,user_birthday,user_interests,user_likes,user_website,user_location,user_work_history'};
 
     // init the Facebook API
     FB.init({
@@ -177,7 +175,7 @@
                 {
                     vBfb.do_fbRedirect();
                 }
-            }, this.loginperms);
+            }, vBfb.loginscope);
         }
     });
 } 


Which, to be blunt, means nothing to me.

I tried editing the vbulletin_facebook.js (as that is the name of the file judging by information supplied) and it did nothing aside from stop my fb connect functioning entirely.


Any ideas on what I'm supposed to do with this, anyone?

[Disasterpiece]

This seems to be a diff file. You can easily see which lines are added (+++) and which removed (---) in which line segments, starting from the first number, with a length specified after the ","

there should be programs out there who are capable of performing those generated changes on their own, but i'm not sure where to find them.

So either you try to understand what this means (as I explained above, also see: http://www.freediff.com/) or you wait for a vbulletin update fixing this problem.

[karlm]

Thanks for the information, DP.. Shame the team can't answer these seemingly simple questions.

[Adrian Schneider]

If you're on linux, you'd run something like...

cd /path/to/your/forums
patch < /path/to/the/patch

It will automatically apply the changes outlined in that text file to the current working directory (vBulletin root).

[Lynne]

The same question was just asked on vbulletin.com this morning and answered. I figured it was by you also.

Also, you should realize that if you want an official answer, you need to ask on vbulletin.com, not here. This site is run by volunteers, not by "the team" (even if some of us are also mods on vb.com - vb.org is not a part of our 'job').