Any MySQL experts? Help is needed

[Farcaster]

Originally Posted by TalkVirginia

The way I understand it is members that are not inactive are getting emails and members that are known to be inactive are not being found, however, I have reason to believe that the people this is happening to have not updated their copy of the addon to the recent changes because the addon has been working on my development site and my live site.

Looking at the code you pasted, I don't see any reason why that might might get the wrong subset of data based on the last activity date. Do you have the SQL from the previous version that might have had a problem?

Originally Posted by TalkVirginia

What this is doing is converting the Unix time stamp to a date then subtracting the current date/time from the date the member was last active on site. It then gets the difference in days comparing that with the integer value entered in the addon settings screen (graceperiod).

I understand how the function is working, but what I am saying is that you are converting two unixtime values and then comparing them when you could do it manually, which would allow your query to take advantage of any indexing available on that field instead of doing a table scan. It would also be quicker since it doesn't have to run each value through a function. Of course, with most boards and the relatively small amount of rows you are talking about, this probably wouldn't be noticeable.