Is this proper coding?

[kh99]

If you're going for shortest code, how about:

PHP Code:

$totalthreads += !$totalthreads;
$totalposts += !$totalposts; 


Anyway, I'm not a php expert but I think I'd go for readability unless it's in a critical area where you're specifically worried about the speed. If the point is to make sure $totalthreads and $totalposts are a positive number, I'd probably go with

PHP Code:

if ($totalthreads < 1)
{
    $totalthreads = 1;
}
if ($totalposts < 1)
{
    $totalposts = 1;
} 


even if it's not "supposed" to ever be less than 0. (ETA: or on second thought maybe using max() would make the intention more obvious).