Attachment.php

[rin]

Hey thanks! =) Your code works properly.
Now I tried to stop the script from executing.
I tried using die() and exit() but both did not stop the script from showing the attachment.
What would I need to do in order to stop the attachment from showing up?

[Dismounted]

exit; should stop execution of the script. Are you sure the code is actually run?

[rin]

What I tried was to create a new plugin with hook "attachment_start" and with the simple line exit(). But still, the attachment would show up. I cleared the cache and it still showed up.

--------------- Added [DATE]1250506111[/DATE] at [TIME]1250506111[/TIME] ---------------

Got it working now.
Strange thing is, it will not exit the script when the thumb and attachment have been cached before?
Is there a better hook for this purpose than attachment_start?

--------------- Added [DATE]1250506751[/DATE] at [TIME]1250506751[/TIME] ---------------

It is very strange. On my test installation, it would work with 2 pictures, it would not work with another and it would show the path to the other instead of anything else.

[AndrewD]

Originally Posted by rin

What I tried was to create a new plugin with hook "attachment_start" and with the simple line exit(). But still, the attachment would show up. I cleared the cache and it still showed up.

--------------- Added [DATE]1250506111[/DATE] at [TIME]1250506111[/TIME] ---------------

Got it working now.
Strange thing is, it will not exit the script when the thumb and attachment have been cached before?
Is there a better hook for this purpose than attachment_start?

--------------- Added [DATE]1250506751[/DATE] at [TIME]1250506751[/TIME] ---------------

It is very strange. On my test installation, it would work with 2 pictures, it would not work with another and it would show the path to the other instead of anything else.

I imagine this is a consequence of how your browser handles files. attachment.php sends a series of browser headers, including some which allow the browser to cache the file for a year. Once those headers have been sent, you no longer have control over file delivery because it is being picked up locally and not retransmitted.

[rin]

Yup, I have just tried around a little bit and found out that cached attachments are shown in either case.
May I ask for help on this one:

$query = $db->query_read("SELECT current_bandwidth FROM " . TABLE_PREFIX . "user WHERE userid = " . $vbulletin->userinfo[userid]);

$add = $query[current_bandwidth] + 550;

Either the mySQL query is corrupt or the value of $query[current_bandwidth] is 0. Which it should not be since it has some value in the database. My guess would be that I can not call the value via the method I used. But after searching around, also in vBulletin code I didn't find a suitable solution.

[AndrewD]

Originally Posted by rin

Yup, I have just tried around a little bit and found out that cached attachments are shown in either case.
May I ask for help on this one:

$query = $db->query_read("SELECT current_bandwidth FROM " . TABLE_PREFIX . "user WHERE userid = " . $vbulletin->userinfo[userid]);

$add = $query[current_bandwidth] + 550;

Either the mySQL query is corrupt or the value of $query[current_bandwidth] is 0. Which it should not be since it has some value in the database. My guess would be that I can not call the value via the method I used. But after searching around, also in vBulletin code I didn't find a suitable solution.

Reading from the database is a two-stage process, unless you are sure that there is only a single record to fetch. You either use the following sequence:

$asb = $vbulletin->db->query_read("
	SELECT current_bandwidth FROM " . TABLE_PREFIX . "user 
	WHERE userid = " . $vbulletin->userinfo[userid]);
while ($query = $vbulletin->db->fetch_array($asb)) {
// process record
}

or, if you arre certain there is one record only, the following:

$query = $vbulletin->db->query_first("
	SELECT current_bandwidth FROM " . TABLE_PREFIX . "user 
	WHERE userid = " . $vbulletin->userinfo[userid]);

[rin]

Great news. You just helped me to get the script working. Here's the code:

$limit = 10000000;
$query = $vbulletin->db->query_first("
	SELECT current_bandwidth FROM " . TABLE_PREFIX . "user 
	WHERE userid = " . $vbulletin->userinfo[userid]);

$add = $query['current_bandwidth'] + $attachmentinfo['filesize'];

$vbulletin->db->query_write("
	UPDATE " . TABLE_PREFIX . "user 
	SET current_bandwidth = $add
	WHERE userid = " . $vbulletin->userinfo[userid]
	);
if($add > $limit)
{ exit(); }

Working! One more thing I was wondering, if exiting the script like this, it will cache a blank attachment. So in case I up the limit a bit, it will not reload the actual attachment, but still show the blank one. I guess there's no easy way around this except for emptying the cache.
Also, currently, when the limit is crossed, it will show a blank attachment. Is it possible to use the space for a proper message telling the user that their bandwidth has exceeded the allowance?
Simply adding a print wouldn't do the trick.

[AndrewD]

Originally Posted by rin

One more thing I was wondering, if exiting the script like this, it will cache a blank attachment. So in case I up the limit a bit, it will not reload the actual attachment, but still show the blank one. I guess there's no easy way around this except for emptying the cache.

Also, currently, when the limit is crossed, it will show a blank attachment. Is it possible to use the space for a proper message telling the user that their bandwidth has exceeded the allowance?
Simply adding a print wouldn't do the trick.

You need to construct and send an appropriate html error page, including non-caching headers.

[rin]

I found this article. Is it helpful to follow some of its instructions for the task that you described?
https://vborg.vbsupport.ru/showthread.php?t=98009

[AndrewD]

Originally Posted by rin

I found this article. Is it helpful to follow some of its instructions for the task that you described?
https://vborg.vbsupport.ru/showthread.php?t=98009

You could simply try:

eval(standard_error('Unable to download attachment - bandwidth allowance exceeded'));