Problem with If-Else If-Else Conditional in Plugin

[Lynne]

Yep, you are right. I didn't think about that when I wrote it (and don't have another plugin using that location, so I haven't had problems.... yet!).

[wottech]

Ok, I am starting over from scratch and trying to slowly build the plugin back to what it was. But, of course, I am running into problems right away.

PHP Code:

if(THIS_SCRIPT == 'showpost' OR THIS_SCRIPT == 'showthread')
{
$hook_query_fields .= ",garage_user_vehicle.user_id AS garageuser"; 
$hook_query_joins .= "LEFT JOIN " . TABLE_PREFIX . "garage_makes AS makes ON(garage_user_vehicle.make_id = garage_makes.id)";
} 


It is getting added to the query, but results in an error saying the column doesn't exist. If I replace the "user_id" with *, then it says the table doesn't exist. This is on a bare bones dev system as well as a direct query via phpmyadmin. If I take out that call, the query runs just fine. But, I can also run a normal query to access just that table with no issues.

Any ideas?!?

EDIT: Here is the actual error I am getting...

Database error in vBulletin 3.8.2:

Invalid SQL:

		SELECT
			post.*, post.username AS postusername, post.ipaddress AS ip, IF(post.visible = 2, 1, 0) AS isdeleted,
			user.*, userfield.*, usertextfield.*,
			icon.title as icontitle, icon.iconpath,
			avatar.avatarpath, NOT ISNULL(customavatar.userid) AS hascustomavatar, customavatar.dateline AS avatardateline,customavatar.width AS avwidth,customavatar.height AS avheight,
			spamlog.postid AS spamlog_postid,
			deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason,
			editlog.userid AS edit_userid, editlog.username AS edit_username, editlog.dateline AS edit_dateline,
			editlog.reason AS edit_reason, editlog.hashistory,
			postparsed.pagetext_html, postparsed.hasimages,
			sigparsed.signatureparsed, sigparsed.hasimages AS sighasimages,
			sigpic.userid AS sigpic, sigpic.dateline AS sigpicdateline, sigpic.width AS sigpicwidth, sigpic.height AS sigpicheight,
			IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid, infractiongroupid
			
			,garage_user_vehicle.user_id AS garageuser
		FROM vb_post AS post
		LEFT JOIN vb_user AS user ON(user.userid = post.userid)
		LEFT JOIN vb_userfield AS userfield ON(userfield.userid = user.userid)
		LEFT JOIN vb_usertextfield AS usertextfield ON(usertextfield.userid = user.userid)
		LEFT JOIN vb_icon AS icon ON(icon.iconid = post.iconid)
		LEFT JOIN vb_avatar AS avatar ON(avatar.avatarid = user.avatarid) LEFT JOIN vb_customavatar AS customavatar ON(customavatar.userid = user.userid)
		LEFT JOIN vb_spamlog AS spamlog ON(spamlog.postid = post.postid)
			LEFT JOIN vb_deletionlog AS deletionlog ON(post.postid = deletionlog.primaryid AND deletionlog.type = 'post')
		LEFT JOIN vb_editlog AS editlog ON(editlog.postid = post.postid)
		LEFT JOIN vb_postparsed AS postparsed ON(postparsed.postid = post.postid AND postparsed.styleid = 1 AND postparsed.languageid = 1)
		LEFT JOIN vb_sigparsed AS sigparsed ON(sigparsed.userid = user.userid AND sigparsed.styleid = 1 AND sigparsed.languageid = 1)
		LEFT JOIN vb_sigpic AS sigpic ON(sigpic.userid = post.userid)
			LEFT JOIN vb_garage_makes AS makes ON(garage_user_vehicle.make_id = garage_makes.id)
		WHERE post.postid IN (0,1)
		ORDER BY post.dateline;

MySQL Error   : Unknown column 'garage_user_vehicle.user_id' in 'field list'
Error Number  : 1054
Request Date  : Thursday, May 7th 2009 @ 05:18:47 PM
Error Date    : Thursday, May 7th 2009 @ 05:18:47 PM
Script        : http://bszopi.net/showthread.php?t=1
Referrer      : http://bszopi.net/forumdisplay.php?f=2
IP Address    : xxx.xxx.xxx.xxx
Username      : bszopi
Classname     : vB_Database
MySQL Version : 5.0.67-community

[RLShare]

By judging from your first post 'garage_user_vehicle' is another table, you are not joining that table into the query so how is Mysql supposed to know what you are looking for. You are only including the 'garage_makes' table.

[wottech]

So my first LEFT JOIN using the showthread_query hook needs to be to include 'garage_user_vehicle' then? Let me go try that...

Yeah, that didn't work either...

PHP Code:

if(THIS_SCRIPT == 'showpost' OR THIS_SCRIPT == 'showthread')
{
$hook_query_fields .= ",garage_user_vehicle.*"; 
$hook_query_joins .= "LEFT JOIN " . TABLE_PREFIX . "garage_user_vehicle AS uservehicle ON(garage_user_vehicle.user_id = post.userid)";
} 


It is still not seeing garage_user_vehicle as a valid table. If someone could explain how I can associate the garage "user_id" to the post "userid" using the showthread_query, I would greatly appreciate it. If I can get that far, then I can probably figure out the rest of it (maybe). Thanks for the help so far...

--------------- Added [DATE]1241738473[/DATE] at [TIME]1241738473[/TIME] ---------------

Ok finally figured it out! Now to continue on with the rest of the queries...

--------------- Added [DATE]1241747134[/DATE] at [TIME]1241747134[/TIME] ---------------

Ok, I am finally back to the original issue - the IF-ELSE IF-ELSE conditional not working inside the plugin. I think I have another issue with the ORDER statement, as in 1 instance I am trying to retrieve up to 10 entries, but that causes the post to repeat itself. I may just have to do away with that as an option... Anyway, here are the 2 plugins I currently have working using the showthread_query:

PHP Code:

if(THIS_SCRIPT == 'showpost' OR THIS_SCRIPT == 'showthread')
{
   switch ($vbulletin->options['postbittype'])
    {
      case 1: $pbq = ",uservehicle.main_vehicle DESC LIMIT 1"; break;
      case 2: $pbq = ",uservehicle.main_vehicle DESC LIMIT 1"; break;
      case 3: $pbq = ",uservehicle.vehicle_id DESC LIMIT 10"; break;
    }  
$postorder .= $pbq;
$hook_query_fields .= ",uservehicle.user_id AS garageuser"; 
$hook_query_fields .= ",makes.make AS garagemake";
$hook_query_fields .= ",uservehicle.made_year AS garageyear";
$hook_query_fields .= ",models.model AS garagemodel";
$hook_query_joins .= "LEFT JOIN " . TABLE_PREFIX . "garage_user_vehicle AS uservehicle ON(uservehicle.user_id = post.userid)";
$hook_query_joins .= "LEFT JOIN " . TABLE_PREFIX . "garage_makes AS makes ON (uservehicle.make_id = makes.id)";
$hook_query_joins .= "LEFT JOIN " . TABLE_PREFIX . "garage_models AS models ON (uservehicle.model_id = models.id)";
} 


PHP Code:

$newyr = substr($post[garageyear], -2);
$gi = 0;

    if($vbulletin->options['postbittype'] == 3)
    {
        while ($gi<10) {     
                $template_hook['postbit_userinfo_right_after_posts'] .= "<div>Test</div>";
                $gi = $gi+1;
                }     
    } else if($vbulletin->options['postbittype'] == 2) {
        $template_hook['postbit_userinfo_right_after_posts'] .= "<div><img src='images/garage/car.png'><a href=garage.php?do=user_garage_view&id=$post[garageuser]> $post[username]'s Garage</a></div>";
    } else {
        $template_hook['postbit_userinfo_right_after_posts'] .= "<div><a href=garage.php?do=user_garage_view&id=$post[garageuser]>'$newyr $post[garagemake] $post[garagemodel]</a></div>";
       } 


I know the postbittype is being set, as it is in the db correctly, and as stated earlier, when it tries to return multiple entries (and that option is set), then the same post is displayed X number of times. So what are the possible issues with the conditional which is causing it not to work? Thanks!