Noobie array help, please.

[robertpro2a]

Hi,
This should be easy but I'm not sure where to go from here. I made a "search.php" file that queries a mySQL db and I want the result to be shown in a VB template. So, I have succesfully duplicated the vb template:


(I won't show all the code b/c you all know what it looks like, but for reference it's this I'm talking about) :

PHP Code:

<?php

// ####################### SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);

// #################### DEFINE IMPORTANT CONSTANTS #######################
define('NO_REGISTER_GLOBALS', 1);
define('THIS_SCRIPT', 'Range Locator'); // change this depending on your filename

I can make it say "HELLO WORLD!!" using the forum template.



After the above code, I connect to the database and run a query.

I have the results stored in a recordset like this:

PHP Code:

function get_ranges($query)
{
 
$result = mysql_query($query);

    $data = array();

    $row = 0;
    while ($r = mysql_fetch_assoc($result)){
        foreach ($r as $key => $value){
            $data[$row][$key] = $value;
        }
        $row++;
    }


    return  $data;

} 


How do I store that into some vb variable so I can access it in the HTML template later?


Something like this?


$array= construct_navbits($array);



Thanks.

[TigerC10]

No, you'll do like this

$myarray = get_ranges("...");

In between the parenthesis and quotes, replace the ... with the SQL statement.




Although if you're using the vBulletin database, there's a better way of executing the query than what you're using...

[Dismounted]

You want to use the vBulletin database class instead (as it also does MySQLi).

PHP Code:

$array = array();
$data = $vbulletin->db->query_read("
    SELECT *
    FROM table
");

while ($row = $vbulletin->db->fetch_array($data))
{
    $array[$row['primaryid']] = $row;
} 


[robertpro2a]

Thank you both.

Dismounted: quick question. I'm not trying to trick you into writing the code for me, but I need a bit of help, please.

My query is fine, but if you'd like to see it here it is:

PHP Code:

//query
$query = "SELECT * From `gun_ranges` where `state` = '$state' "; 


I need to retrieve 5 columns of data from that. So, using your code, would I do this?

PHP Code:

 $array = array();
$data = $vbulletin->db->query_read(    $query );

while ($row = $vbulletin->db->fetch_array($data))
{
 
    $array[$row['website']] = $row; //gun range's website
 
    $array[$row['phone']] = $row; //gun range's phone number

   //etc....
} 


Is this correct? And if so, could you please point me in the direction on how I would retrieve this information via the template HTML?

Thank you.

[TigerC10]

Man you weren't kidding when you said "noobie". You've got it backwards. Your query could be improved too...

PHP Code:

$array = array();
$query = "SELECT * From ".TABLE_PREFIX."gun_ranges where state = '$state' ";
$data = $vbulletin->db->query_read( $query );
$count = 0;
while ($row = $vbulletin->db->fetch_array($data))
{
 
    $array[$count]['website'] = $row['website']; //gun range website
    $array[$count]['phone'] = $row['phone']; //gun range phone number

    //etc....

    $count+=1;
} 

echo "0's Website: ". $array[0]['website']; 


Alternatively...

PHP Code:

$array = array();
$query = "SELECT * From ".TABLE_PREFIX."gun_ranges where state = '$state' ";
$data = $vbulletin->db->query_read( $query );
$count = 0;
while ($row = $vbulletin->db->fetch_array($data))
{
 
    $array[$count] = $row; //copies everything all at once

    $count+=1;
} 

echo "0's Website: ". $array[0]['website']; 


[Dismounted]

PHP Code:

$templatebits = '';
$data = $vbulletin->db->query_read("
    SELECT *
    FROM gun_ranges
    WHERE state = '" . $vbulletin->db->escape_string($state) . "'
    LIMIT 5
");

while ($row = $vbulletin->db->fetch_array($data))
{
    eval('$templatebits .= "' . fetch_template('templatebit') . '";');
} 


[TigerC10]

Dismounted, do you really think that $state is a user inputted variable?

[Dismounted]

User-input or not, it needs to be cleaned beforehand.

Hypothetical: Assume it was added by Admins through the Admin CP. Unknowing Admin uses single quotes. Bam! Your query fails.

[TigerC10]

True, but this guy is making a $query variable instead of inlining the string. I think he's done the same thing with something in the $state variable.

But I guess it's better to be safe than sorry.

[robertpro2a]

Hi guys,
Well, my SQL is fine since I actually did sql injection prevention before the query..but in regards to the other codes, they are causing the php page to turn blank, which means there is an error...

Tiger: I think the reason why yours is doing it is because you can't echo within the php file, since its meant to display the template.

Dismounted: I'm not sure why yours isn't working either.

...still grateful for the help so far!!