Need some help finishing a hack.

[Scott MacVicar]

PHP Code:

<a href="javascript:showforumrules(420,512,'$session[sessionhash]','$foruminfo[forumid]')">Forum Rules</a> 


function showforumrules(x,y,sessionhash,forumid) {
                window.open("misc.php?action=showforumrules&forumid="+forumid+"&s="+sessionhash, "smilies", "toolbar=no,scrollbars=yes,resizable=yes,width="+x+",height="+y);
}

I ain't no javascript expert but that should hopefully work