Portal Software - A Better News Module Fix for vBadvanced CMPS 2.2.1

vBadvanced has released CMPS 2.2.1 with a substandard fix to the News module bug that has plagued many vBulletin forums for months.

Volconvo.com and developer Sillysoft are offering a free and better fix.


BACKGROUND

In version 2.2.0, the problem occurred when when the maximum characters variable was set at such a number that it precluded the display of closing BBCode tags. (thumb: news_verybad.png)

Version 2.2.1 "resolved" the issue by ending quoted material prematurely, effectively ignoring the actual maximum character value. (thumb: news_bad.png)

Volconvo.com and developer Sillysoft have partnered to offer the following better fix for vBadvanced CMPS that respects your personal settings. (thumb: news_good.png)


INSTALLATION

1. Find this line in [forumdirectory]/modules/news.php:
   PHP Code:

    $news['message'] = substr($news['message'], 0, strrpos(substr($news['message'], 0, $mod_options['portal_news_maxchars']), ' ')); 

   Replace with the following code:
   PHP Code:

   // START BUG FIX
// Provided by Volconvo.com and Sillysoft
// http://www.volconvo.com/cmps.php?page=newsmodulefix
// Original code:
// $news['message'] = substr($news['message'], 0, strrpos(substr($news['message'], 0, $mod_options['portal_news_maxchars']), ' '));

                    $rawdata = $news['pagetext'];
                    $newspart1 = substr($rawdata,0,$mod_options['portal_news_maxchars']);
                    $newsposition = strrpos($newspart1,' ');
                    $newspart1 = substr($newspart1,0,$newsposition);
                    
                    $rawdata = $rawdata .'.';
                    $newspart2 = substr($rawdata,$newsposition,-1);
                    
                    preg_match_all('#(\[(.*?)\])?.*?(\[\/(.*?)\])?#',$newspart2,$newspart2tags); 
                    $numtags = count($newspart2tags[0]);
                    $tags = '';
                    
                    for($i = 0; $i < $numtags; $i++)
                    { 
                        
                        $tags .= $newspart2tags[1][$i] . $newspart2tags[3][$i];
                             
                    }
                    
                    $shownews = $newspart1 .'...';
                    $news['message'] = $bbcode_parser->do_parse($shownews, $mod_options['portal_news_enablehtml'], $news['allowsmilie'], $mod_options['portal_news_enablevbcode'], $mod_options['portal_news_enablevbimage']);

// END BUG FIX 

2. Click INSTALL.

CHANGE LOG

11/6/06: Update to better handle images as provided here.

CREDITS

This fix was developed by Sillysoft in partnership with Volconvo.

You may contact Sillysoft at liquidchaoss (at) yahoo.com or via AIM at "Sillysoft".
The Volconvo administrator may be contacted here.

[ComputerVitals]

Thanks for the added fix.

[CBrown]

This works well, but one issue.

Fix this line:

$shownews = $newspart1 .'...' .$tags;

and replace with:

$shownews = $newspart1 .'...';

Otherwise a post with lots of images prints all the image tags in a row and stretches out the theme.....

[voteforbird]

Thanks! Updated.

[jellybeanz]

Hmm after applying the latest changes my news no longer parses bbcode.

[voteforbird]

I don't believe that problem has occurred for me or anyone else. Can I get some confirmation on that?

[jellybeanz]

Here are my before and after pics.

[Tulsa]

I'll second that issue.

[Inferno Dragon]

hey thanks for the hack, I was about to install it but the installation instructions in the .txt file is totally a mess check it out please!

[Inferno Dragon]

Ok I installed it and I am having the same issue like jellybeanz i-e it's not parsing bbcode within news :\