Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 11-10-2006, 08:18 AM
Rawhide Rawhide is offline
 
Join Date: Oct 2006
Posts: 16
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Custom Image Code - Need Security

I'm working on some custom image code, not unlike the [img] tag.

What is the best way to ensure that:
a) the url starts with http:// (not https://)
b) the filetype is .jpg, .gif or .png
c) the url contains no spaces, <, >, ?, $, &, [, ], html, or other symbols that could be harmful
d) the url only contains letters, numbers, /, and .
e) if possible, information on how to check to see that the image is a valid image file
f) not required, but information on how to implement dimension checking would be useful too

If anyone could assist me with the best way of doing these, it would be much appreciated.
Reply With Quote
  #2  
Old 11-13-2006, 10:24 AM
Rawhide Rawhide is offline
 
Join Date: Oct 2006
Posts: 16
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Even if you can only answer one of these queries, or part of one, any assistance would be appreciated.
Reply With Quote
  #3  
Old 11-13-2006, 11:35 AM
Viper007Bond's Avatar
Viper007Bond Viper007Bond is offline
 
Join Date: Oct 2006
Location: Portland, OR, USA
Posts: 224
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

e) Not possible without using PHP to download the image file and then examine it with some image functions from the GD module.

As for the rest, something like this would probably do I think:

PHP Code:
$text preg_replace('#\[yourtag\]http://([A-Za-z/.]+)\.(jpg|gif|png)\[/yourtag\]#si''<img src="http://$1.$2" alt="" />'$text); 
Reply With Quote
  #4  
Old 11-13-2006, 08:11 PM
Rawhide Rawhide is offline
 
Join Date: Oct 2006
Posts: 16
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thank you! I haven't used your code specifically, but it was exactly what I needed to know.

Because this is going in a user profile field, I haven't needed to specifically write php code for it, instead I used the preg_match feature of the user profile field. Below is the characters I am currently allowing, I have added 0-9, ~, _ and - and allowed for a blank entry.
PHP Code:
^http://([A-Za-z0-9/.~_-]+)\.(jpg|gif|png)$|^$ 
It now supports the ability to set the image dimensions between 20 and 120 pixels with the below regular expression on two other mandatory user profile fields.
PHP Code:
^([2-9][0-9]|11[0-9]|120)$ 
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 02:29 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03722 seconds
  • Memory Usage 2,189KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (3)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (4)post_thanks_box
  • (4)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (4)post_thanks_postbit_info
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete