What's wrong with my While Loop?

[Kirk Y]

Does anyone see something wrong with the while loop below? It's only returning 1 string, when there are in fact more than 10.

PHP Code:

 $thread_sql = mysql_query("SELECT threadid,title,lastpost,lastposter,forumid FROM thread WHERE visible=1 $wheresql AND open=1 ORDER BY lastpost DESC LIMIT 10");
 
 while($thread_get=mysql_fetch_array($thread_sql))
 {
 $lastpost = $thread_get['lastpost'];
 $poster = $thread_get['lastposter'];
 $tid = $thread_get['threadid'];
 $psql = mysql_query("SELECT postid FROM post WHERE threadid=$tid ORDER BY postid DESC");
 $getp=mysql_fetch_array($psql);
 $pid = $getp['postid'];
 $date2 = date ("m/d/y h:i A" ,$lastpost);
 $title = $thread_get['title'];
 $title = substr($title,0,$txtlimit);
 $output = "$title";
 } 


Originally Posted by acidburn0520

Does anyone see something wrong with the while loop below? It's only returning 1 string, when there are in fact more than 10.

PHP Code:

 $thread_sql = mysql_query("SELECT threadid,title,lastpost,lastposter,forumid FROM thread WHERE visible=1 $wheresql AND open=1 ORDER BY lastpost DESC LIMIT 10");
 
 while($thread_get=mysql_fetch_array($thread_sql))
 {
 $lastpost = $thread_get['lastpost'];
 $poster = $thread_get['lastposter'];
 $tid = $thread_get['threadid'];
 $psql = mysql_query("SELECT postid FROM post WHERE threadid=$tid ORDER BY postid DESC");
 $getp=mysql_fetch_array($psql);
 $pid = $getp['postid'];
 $date2 = date ("m/d/y h:i A" ,$lastpost);
 $title = $thread_get['title'];
 $title = substr($title,0,$txtlimit);
 $output = "$title";
 } 


What is $psql? You really shouldn't be running a query inside a while loop. It can cause intense server load.

By results, do you mean the value of $output?

If so, you are not appending your results to a variables just setting the variable with each new row.

[Kirk Y]

It's an excerpt from a script I got somewhere from here. So, what exactly is wrong with it?

[Paul M]

It looks like it could do with rewriting, what's it supposed to be doing ?

[Kirk Y]

Getting the latest posts from specific forums. Like I said, I was in a hurry and just took it from some old post.

[Adrian Schneider]

You are resetting it every time with your assignments. Use .= if you want to add to a string instead.

PHP Code:

$string .= 'add this'; 


[Paul M]

Originally Posted by acidburn0520

Getting the latest posts from specific forums. Like I said, I was in a hurry and just took it from some old post.

Then its a dreadful piece of code. You would be better throwing it away and looking/asking for something better.

[Kirk Y]

Shoot. Have to end up writing in after all, oh well. Thanks.

[harmor19]

I wrote this a while back.

PHP Code:

$getthreads = $db->query_read("SELECT * FROM " . TABLE_PREFIX . "thread WHERE forumid='5' ORDER BY threadid DESC LIMIT 10");    
while($lt = $db->fetch_array($getthreads))
{
   $latestthreads .= "Title: <a href='showthread.php?t=$lt[threadid]'>".$lt['title']."</a> | Posted By: <a href='member.php?u=$lt[postuserid]'>".$lt['lastposter']."</a><br />";

} 


[Kirk Y]

Thanks Harmor. I actually already wrote one, basically the same - only I didn't know how to get the lastpostuserid. Thanks, though.