Go Back   vb.org Archive > vBulletin Modifications > Archive > vB.org Archives > Premium Archives > vbBux / vbPlaza
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools
redundant queries from installation code? Details »»
redundant queries from installation code?
Version: , by mtha mtha is offline
Developer Last Online: May 2016 Show Printable Version Email this Page

Version: Unknown Rating:
Released: 07-03-2006 Last Update: Never Installs: 0
 
No support by the author.

CMX,

I've been looking at your vb Plaza installation code, and wondering why you use alot of seperate queries while you can merge them together? Shouldnt it save queries, and run better/faster in the installation process?


example:
PHP Code:
$db->query_write("ALTER TABLE " TABLE_PREFIX "user ADD COLUMN vbbux DECIMAL(30, 5) NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user ADD COLUMN vbbank DECIMAL(30, 5) NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user ADD COLUMN vbp_nextbankinterest INT UNSIGNED NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user ADD COLUMN vbp_lastbirthday INT UNSIGNED NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user ADD COLUMN vbp_displayflags INT UNSIGNED NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user ADD COLUMN vbp_otherflags INT UNSIGNED NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user ADD COLUMN vbp_vbplazaoptions INT UNSIGNED NOT NULL DEFAULT '0'"); 
why dont use
PHP Code:
$db->query_write("ALTER TABLE " TABLE_PREFIX "user 
ADD COLUMN vbbux DECIMAL(30, 5) NOT NULL DEFAULT '0', 
ADD COLUMN vbbank DECIMAL(30, 5) NOT NULL DEFAULT '0',
ADD COLUMN vbp_nextbankinterest INT UNSIGNED NOT NULL DEFAULT '0',
ADD COLUMN vbp_lastbirthday INT UNSIGNED NOT NULL DEFAULT '0',
ADD COLUMN vbp_displayflags INT UNSIGNED NOT NULL DEFAULT '0',
ADD COLUMN vbp_otherflags INT UNSIGNED NOT NULL DEFAULT '0',
ADD COLUMN vbp_vbplazaoptions INT UNSIGNED NOT NULL DEFAULT '0',
... 

OR with

PHP Code:
$db->query_write("ALTER TABLE " TABLE_PREFIX "user DROP COLUMN vbbux");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user DROP COLUMN vbbank");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user DROP COLUMN vbp_nextbankinterest");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user DROP COLUMN vbp_lastbirthday");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user DROP COLUMN vbp_displayflags");
$db->query_write("ALTER TABLE " TABLE_PREFIX "user DROP COLUMN vbp_otherflags"); 

PHP Code:
$db->query_write("ALTER TABLE " TABLE_PREFIX "user 
DROP COLUMN vbbux, 
DROP COLUMN vbbank,
DROP COLUMN vbp_nextbankinterest,
DROP COLUMN vbp_lastbirthday,
DROP COLUMN vbp_displayflags,
DROP COLUMN vbp_otherflags,
... 

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.

Comments
  #2  
Old 07-13-2006, 07:26 PM
CMX_CMGSCCC CMX_CMGSCCC is offline
 
Join Date: Sep 2003
Posts: 1,218
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

True, I could probably do all of these, but its a minute point at this time, as I will be working on V2.0 very soon, I will probably incorporate these changes into V2.0

-CMX
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 10:39 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03818 seconds
  • Memory Usage 2,218KB
  • Queries Executed 17 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (4)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (6)navbar_link
  • (120)option
  • (2)post_thanks_box
  • (2)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (2)post_thanks_postbit_info
  • (1)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete