Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 06-11-2006, 03:33 PM
bairy bairy is offline
 
Join Date: Oct 2005
Posts: 184
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Why is HTML in forums so dangerous?

In the forum manager // Allow HTML // Admin Help it says

Quote:
This allows users to use HTML while posting. It is strongly recommended that you DO NOT turn this on as it can severely compromise security and/or severely mess up layout if users insert malformed HTML. Even if you set this to Yes, users still cannot use certain tags, including javascript: and about:.
Aside from screwing up the layout, why is it so dangerous? And couldn't the vb team put a filter of 'safe' tags as other sites (blogger, livejournal) do?
I know you can use vbcode and that's fine, and you can make new code to cover tags such as <strike>. It's just sometimes a <table> with css would be really useful in a post.
Reply With Quote
  #2  
Old 06-11-2006, 03:44 PM
Adrian Schneider's Avatar
Adrian Schneider Adrian Schneider is offline
 
Join Date: Jul 2004
Posts: 2,528
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by bairy
In the forum manager // Allow HTML // Admin Help it says



Aside from screwing up the layout, why is it so dangerous? And couldn't the vb team put a filter of 'safe' tags as other sites (blogger, livejournal) do?
I know you can use vbcode and that's fine, and you can make new code to cover tags such as <strike>. It's just sometimes a <table> with css would be really useful in a post.
People can steal your cookie information, then load it into their browser and be logged in as you. They can also post harmful content (movies, images, etc). If they were to post <base> tags or iframes, they can muck up all your links or load other sites in your pages.

Javascript is probably the biggest concern, but there many other annoyances.
Reply With Quote
  #3  
Old 06-11-2006, 03:55 PM
Zachariah's Avatar
Zachariah Zachariah is offline
 
Join Date: Feb 2002
Location: Canoga Park, CA
Posts: 2,125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by bairy
Aside from screwing up the layout, why is it so dangerous?
One example: I go to your website all the time. It's great. One day go to a HTML thread on your site made by someone who wants to destroy end-user computers with spyway and virus with 1000's of pop ups.

There are times when I enable HTML

- Site staff access to post only
- trusted usergroup w/ users (people that need it on for whatever reason)
- moderated post/thread rights on the forum if open to every day members


Quote:
And couldn't the vb team put a filter of 'safe' tags as other sites (blogger, livejournal) do? It's just sometimes a <table> with css would be really useful in a post.
I have not looked yet, but I bet there are a few hacks out there with a bunch of BB Codes in 1 package. I recall a lot of CSS/HTML markup BB codes for text some time ago.


Custom BB Codes - vBulletin Manual
Its syntax is similar to HTML, but it has the benefit that you (the administrator) can define exactly what codes are allowable in order to prevent unwanted formatting or malicious use.
Reply With Quote
  #4  
Old 06-12-2006, 08:12 PM
good2laugh good2laugh is offline
 
Join Date: Jul 2002
Location: London
Posts: 51
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Zachariah

There are times when I enable HTML

- Site staff access to post only
- trusted usergroup w/ users (people that need it on for whatever reason)
- moderated post/thread rights on the forum if open to every day members

Hi, you mention trusted usergroup would or could this include users I've "created" to post RSS feeds. they are in a unique group which isn't viewable on groups and isn't joinable.

I've just noticed some of the yahoo alerts post html links which may be pictures of whatever, but just looks a mess. I don't want to moderate every post. As the users are made up by me is it safe to allow them to use html, I mean nobody can hijack their usename right? or wrong?
I've been hacked, as has others with similar forum topics - and that person is still around and determined to take us all down, so its quite important that I keep things as secure as poss - but I like this rss thingy and want it to post correctly.

In relation to this, I assume on VBoptions I have to allow html - and assume I then go to usergroup permissions to disallow it for all groups except my RSS feeders?

I know basic html only and am a master at the find this code, above that, add this code type instructions I get here.. but that is the extent of my knowledge, so please forgive me if I've just asked a bunch of stupid questions.

TIA
Reply With Quote
  #5  
Old 06-13-2006, 02:25 AM
Zachariah's Avatar
Zachariah Zachariah is offline
 
Join Date: Feb 2002
Location: Canoga Park, CA
Posts: 2,125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Here is what I usaly do when I need HTML enabled on a forum, and have all people from a usergroup have access in posting.
  • Create a usergroup that you plan to have access to post HTML.
  • Create a forum with HTML enabled.
  • Select Forum Permissions from menu Forums & Moderators.
- This will show a list of forums and custom options per usergroup per forum.
Find the forum that you made and edit the usergroups and turn off all options in "Post / Thread Permissions" for the usergroups you want to stop from posting.

Everyone you move to the custom usergroup can post in that HTML enabled forum with out problems.
Reply With Quote
  #6  
Old 06-13-2006, 05:03 AM
kall's Avatar
kall kall is offline
 
Join Date: Apr 2004
Location: New Zealand
Posts: 2,608
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Or, if you didnt want to restrict posting for everyone, don't turn on HTML at the Forum Level, use my Mod: https://vborg.vbsupport.ru/showthread.php?t=96926
Reply With Quote
  #7  
Old 06-13-2006, 02:31 PM
Zachariah's Avatar
Zachariah Zachariah is offline
 
Join Date: Feb 2002
Location: Canoga Park, CA
Posts: 2,125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

^_^ - kall nice !!
Reply With Quote
  #8  
Old 06-13-2006, 04:52 PM
good2laugh good2laugh is offline
 
Join Date: Jul 2002
Location: London
Posts: 51
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by kall
Or, if you didnt want to restrict posting for everyone, don't turn on HTML at the Forum Level, use my Mod: https://vborg.vbsupport.ru/showthread.php?t=96926
Brilliant!! Thank you very much.:banana:

To save me doing two posts, Thanks also to Zachariah
Reply With Quote
  #9  
Old 06-13-2006, 08:12 PM
tgreer tgreer is offline
 
Join Date: Oct 2005
Posts: 183
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Also, if you're an XHTML/CSS validation freak, then you'd be allowing users to potentially ruin your markup. Not a security issue, and it wouldn't even necessarily break the site, but if you care about such things, then it matters.

I've considered a form of forum sponsorship which allows vendors in my industry to have their own forum, with HTML enabled, to post newsletters. I've mixed feelings about it.
Reply With Quote
  #10  
Old 06-14-2006, 10:32 PM
antialiasis's Avatar
antialiasis antialiasis is offline
 
Join Date: Jan 2006
Location: Iceland
Posts: 346
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Heh, I made a special hack for forcing signatures with HTML to be approved by a moderator and then I look through them all and change the XHTML to be valid. I'm a markup nazi.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 04:26 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05628 seconds
  • Memory Usage 2,256KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (6)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete