Miscellaneous Hacks - IE11 browser detection and fixes

IE11 gets along pretty well with vB3, though file downloads get a bit wonky due to some changes in how IE is detected.

In includes/functions.php find:

PHP Code:

        // detect macintosh 


Add above:

PHP Code:

// Detect Modern IE11+
        if (strpos($useragent, 'trident') !== false AND !$is['opera'] AND !$is['ie'])
        {
            preg_match('#rv:([0-9\.-]+)#', $useragent, $regs);
            $is['ie'] = $regs[1];
 
        } 


Next, find:

PHP Code:

if (strpos($useragent, 'gecko') !== false AND !$is['safari'] AND !$is['konqueror']) 


And replace it with

PHP Code:

if (strpos($useragent, 'gecko') !== false AND !$is['safari'] AND !$is['konqueror'] AND !$is['ie']) 


[Zachery]

You do that then...

[Max Taxable]

But only if it's okay with you.

[BirdOPrey5]

Only the mod author is allowed 1 reserved post directly below their modification post. Reserved posts aren't permitted elsewhere on the site.

[Max Taxable]

Originally Posted by BirdOPrey5

Only the mod author is allowed 1 reserved post directly below their modification post. Reserved posts aren't permitted elsewhere on the site.

Ahh, live and learn! I always thought it was for the purpose of subscribing to a thread to make it easy to find later! Reserving installation for a later time but keeping track of progress in the thread.

NOW I understand.

[Zachery]

TAg, or install it, if you want to keep dibs on it

[Zachery]

Made a small change to fix a IE10 detection issue.

[cellarius]

Thanks, Zachery! Installed. Do you know whether this will be included into vB3.8.8 before release? Just so I know whether I'll have to remember to redo it after an eventual upgrade.

[Zachery]

I don't think so, I haven't asked about it. But the fix is fairly trivial at least.

[BirdOPrey5]

A bug for IE11 detection is marked as resolved in JIRA-
http://tracker.vbulletin.com/browse/VBIII-12932

Looks like it would fix this issue.