Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 Programming Discussions
  #31  
Old 07-11-2012, 08:12 PM
John Lester John Lester is offline
 
Join Date: Nov 2004
Posts: 543
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ummm hmm let me try something real quick NO the other did not insert a link in the outgoing emails.

--------------- Added [DATE]1342041474[/DATE] at [TIME]1342041474[/TIME] ---------------

Ok with the old one I'd visit urlhere/misc.php?do=unsub and click the unsubscribe button.

This one when I visit urlhere/misc.php?do=unsub I see my smilies page

So I have no idea what's going on right now
Reply With Quote
  #32  
Old 07-11-2012, 08:19 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Oh, sorry, that is my fault. I decided to change the "do" values so that they wouldn't conflict with the other mod (which now that I think about it might not have been a good idea since some people might want to replace the other mod with this one).

Anwyay, the current one uses do=unsubscribe instead of do=unsub.

--------------- Added [DATE]1342041966[/DATE] at [TIME]1342041966[/TIME] ---------------

I guess I should try that dbtech mod. So far this hasn't been a big deal, but before I spend any more time I should make sure I'm not making a poor imitation of what they've done already.
Reply With Quote
  #33  
Old 07-11-2012, 08:27 PM
John Lester John Lester is offline
 
Join Date: Nov 2004
Posts: 543
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ok it works But it can't find phrase klh99_unsublink_done

--------------- Added [DATE]1342042115[/DATE] at [TIME]1342042115[/TIME] ---------------

If you don't mind I'll be tweaking it to turn off those other options as well just to cover my butt
Reply With Quote
  #34  
Old 07-11-2012, 08:33 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by John Lester View Post
Ok it works But it can't find phrase klh99_unsublink_done

--------------- Added [DATE]1342042115[/DATE] at [TIME]1342042115[/TIME] ---------------

If you don't mind I'll be tweaking it to turn off those other options as well just to cover my butt
Yeah, a phrase or two was misnamed (I went and renamed everything because I like to add kh99 and mod name just to avoid possible comflicts). I've been working on little things like that in the current version.

Tweaking what to turn off what? You can do whatever you want of course, but if you want to install the final mod when it's done then you probably won't want to do a lot of phrase editing just yet (unless you don't mind repeating it )

I'm going to try to release a first version tonight. If nothing else that will let us continue this discussion in the mod thread instead of annoying everyone in the forum by continuously bumping this thread .
Reply With Quote
  #35  
Old 07-11-2012, 08:36 PM
John Lester John Lester is offline
 
Join Date: Nov 2004
Posts: 543
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Right now your version only deselects "receive emails from admin", the older one that I tweaked deselects a few more options and sets thread subscriptions to "do not subscribe".

I forgot to attach the tweaks I made to the older mod for you to see

I changed the name of the mod so I wouldn't import the wrong one, but the attached is the old mod with my tweaks.
Attached Files
File Type: xml product-advanced_unsubscribe_link_4.0.xml (8.1 KB, 4 views)
Reply With Quote
  #36  
Old 07-11-2012, 08:40 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by John Lester View Post
Right now your version only deselects "receive emails from admin", the older one that I tweaked deselects a few more options and sets thread subscriptions to "do not subscribe".

I forgot to attach the tweaks I made to the older mod for you to see

I changed the name of the mod so I wouldn't import the wrong one, but the attached is the old mod with my tweaks.
Oh, I see. Good, I'll take a look at that. Yeah, I was thinking about a set of checkboxes for what it should turn off, in the adminCP and maybe optionally on the user form (where you enter the email) so a user could decide what to opt out of.

--------------- Added [DATE]1342042972[/DATE] at [TIME]1342042972[/TIME] ---------------

BTW, I think setting autosubscribe to -1 just stops the automatic adding of subscriptions to threads. If you want to also delete existing subscriptions, you'd have to delete the records from the subscription tables.
Reply With Quote
  #37  
Old 07-11-2012, 08:47 PM
John Lester John Lester is offline
 
Join Date: Nov 2004
Posts: 543
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yes all it does is change the setting, I haven't even attempted to delete existing subscriptions because technically it's not needed since deselecting "receive email from admins" stops them from being sent.

At least that is my understanding of what "receive email from admins" actually does.

--------------- Added [DATE]1342043294[/DATE] at [TIME]1342043294[/TIME] ---------------

The reason I added the change to subscriptions was basically just testing to make sure I understood what I was doing

--------------- Added [DATE]1342043372[/DATE] at [TIME]1342043372[/TIME] ---------------

As you probably have seen with my tweaked version of the old mod, I'll be changing the phrase to something very similar depending on the final product
Reply With Quote
  #38  
Old 07-11-2012, 08:54 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by John Lester View Post
Yes all it does is change the setting, I haven't even attempted to delete existing subscriptions because technically it's not needed since deselecting "receive email from admins" stops them from being sent.

At least that is my understanding of what "receive email from admins" actually does.
Hmm...if it's important to you then I'd test that. Looking at the code, it doesn't look like that's true. In fact after a quick glance it looks like the only things affected by the admin email setting is birthday emails, infraction notices, and emails sent from the admincp (but I may have missed a few things).

I'll try to have a somewhat stable version tonight so you don't have to change things more than once (unless of course you're happy with the current one, then you don't really *have* to install any other version).
Reply With Quote
  #39  
Old 07-11-2012, 09:16 PM
John Lester John Lester is offline
 
Join Date: Nov 2004
Posts: 543
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Well the only emails we send out are: birthday, subscriptions, pm notifies, infractions, and some user to user emails.

I will be putting the url in every "email body text" so I should be covered either way No need to go digging around for past subscription stuff

--------------- Added [DATE]1342046806[/DATE] at [TIME]1342046806[/TIME] ---------------

Well now this is a bit odd, when I click on the "more" link on my smilie page it tells me it can't find the phrase unsubscribe_done and redirects me to the index page O.o
Reply With Quote
  #40  
Old 07-11-2012, 10:28 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by John Lester View Post
Well the only emails we send out are: birthday, subscriptions, pm notifies, infractions, and some user to user emails.

I will be putting the url in every "email body text" so I should be covered either way No need to go digging around for past subscription stuff
Well, in a way that would only make the situation worse, if there was a link but it didn't actually stop the emails.

I've been trying to test if turning off admin emails stops subscription emails, but I'm frustrated by the fact that it can take 10 minutes or more just to receive an email that I send myself. I guess I need to put debug statements in the code to make sure.


Quote:
Well now this is a bit odd, when I click on the "more" link on my smilie page it tells me it
can't find the phrase unsubscribe_done and redirects me to the index page O.o

What does the url say? I don't see how that could happen in my mod - all the code is inside if statements checking the value of "do".

--------------- Added [DATE]1342050219[/DATE] at [TIME]1342050219[/TIME] ---------------

OK - I'd feel better if I could do a "real" test with emails, but I'm pretty sure that turning off admin emails doesn't stop subscription emails. I think the idea is that the users have control over what they subscribe to, so there's no need for a setting.

But, it OK because it's actually an easy query or two to remove all subscirptions for a user.

Well, OK, more than a couple. I was just looking at the database and there's also socialgroup group and discussion subscriptions and event reminders.

Edit: ..and one more thing, I was hoping to release this tonight but I think I'm done with this stuff for today, I hope that's not a problem.

--------------- Added [DATE]1342052683[/DATE] at [TIME]1342052683[/TIME] ---------------

One more thing - I think I am being stupid. While I was testing the subscription emails I noticed that not only does it already contain a link to remove the subscription, the link also has some kind of "auth" code that removes the subscription in one click without needing to log in. I'm going to look in to that tomorrow.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 11:10 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04643 seconds
  • Memory Usage 2,284KB
  • Queries Executed 12 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (5)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (1)postbit_attachment
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • postbit_attachment
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete