Quote:
Originally Posted by CarlitoBrigante
Paul, do not be so dismissive, it is silly. 5 forum upgrades today, all with display errors set to off and errors still displaying. Anyhow, I said "I think" in my post. If the error is not in the error handler, could be elsewhere.
|
OK, since I am a stupid bastard, instead of working on my stuff I decided to jump into it, and it looks like I was right. The implementation of the error_handler in vBulletin 4.2.2 is wrong, or at the very least, incomplete.
The final part of the new error handler, the one matching all errors not matched by previous cases, which means also deprecated errors (those most people in the forums have been having problems with) contains this:
Code:
default:
if (error_reporting() OR ini_get('display_errors'))
{
and vBulletin then proceeds to echo the error.
This means errors will be shown if error_reporting is enabled even if display errors is set to off. A correct implementation of an error_handler needs to follow the configuration settings specified on the server and react accordingly.
More on this here:
http://stackoverflow.com/questions/5...700117#5700117
I do not have the time to submit this to vBulletin's JIRA, so if you guys have the time, do it. I will submit only a trouble ticket for this.
10-10-2013, 01:05 AM
Hybrid Mode
