Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Programming Discussions
FAQ Community Calendar Today's Posts Search

 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
  #1  
Old 05-04-2005, 04:02 PM
Jenta Jenta is offline
 
Join Date: Dec 2004
Posts: 377
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Some code in my phpinclude_start - how would you rewrite this code?

Am I doing this the most efficient and proper way? I don't trust myself much :nervous:

It works but perhaps it's noobish? Can u tell me how to make it more correct?

I'm mostly referring to stuff like changing some things to OR, AND, ELSE and combing it into one statement or whatever.

Will doing so make it parse faster and more effieciently?

Code:
// question 1
if (!defined('IN_PORTAL_AREA')) {

	// question 2
	if (THIS_SCRIPT == 'index')
		{
			// do something
    			$lifetime_posts = $DB_site->query_first("SELECT post.postid 
    			FROM " . TABLE_PREFIX . "post AS post 
    			ORDER BY post.postid DESC 
    			LIMIT 1"); 

    			$lifetime_threads = $DB_site->query_first("SELECT thread.threadid 
    			FROM " . TABLE_PREFIX . "thread AS thread 
    			ORDER BY thread.threadid DESC 
    			LIMIT 1"); 
		}
		
		// question 3
		if (THIS_SCRIPT == 'index' OR THIS_SCRIPT == 'forumdisplay') 
		{
		// do something 
    			$forumcounts= $DB_site->query("SELECT forumid, replycount, threadcount 
        		FROM " . TABLE_PREFIX . "forum 
        	"); 
    		while ($forumcount = $DB_site->fetch_array($forumcounts)) 
    		{ 
       			$forumreply[$forumcount[forumid]] = $forumcount[replycount]; 
        		$forumthread[$forumcount[forumid]] = $forumcount[threadcount]; 
    		} 
}

// question 4
if ($bbuserinfo['userid'] != 1) {
	// question 5
	if (THIS_SCRIPT == 'adv_index')
		{ 
			// do something 
    			include("./forums/statistic_counter.php"); 
		}
	// question 6
	if (THIS_SCRIPT == 'index')
		{
			// do something 
    			include("./statistic_counter.php"); 
		}

}

// question 7
if (defined('IN_PORTAL_AREA')) {
	// do something
	require_once('./global.php');
}
thanks!
Reply With Quote
 


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 03:18 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05013 seconds
  • Memory Usage 2,311KB
  • Queries Executed 12 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (4)post_thanks_box
  • (4)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (4)post_thanks_postbit_info
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)showthread_list
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_threadedmode.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids_threaded
  • showthread_threaded_construct_link
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete