vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   Some code in my phpinclude_start - how would you rewrite this code? (https://vborg.vbsupport.ru/showthread.php?t=80980)

Jenta 05-04-2005 04:02 PM
Some code in my phpinclude_start - how would you rewrite this code?
 
Am I doing this the most efficient and proper way? I don't trust myself much :nervous:

It works but perhaps it's noobish? Can u tell me how to make it more correct?

I'm mostly referring to stuff like changing some things to OR, AND, ELSE and combing it into one statement or whatever.

Will doing so make it parse faster and more effieciently?

Code:

// question 1
if (!defined('IN_PORTAL_AREA')) {

        // question 2
        if (THIS_SCRIPT == 'index')
                {
                        // do something
                            $lifetime_posts = $DB_site->query_first("SELECT post.postid
                            FROM " . TABLE_PREFIX . "post AS post
                            ORDER BY post.postid DESC
                            LIMIT 1");

                            $lifetime_threads = $DB_site->query_first("SELECT thread.threadid
                            FROM " . TABLE_PREFIX . "thread AS thread
                            ORDER BY thread.threadid DESC
                            LIMIT 1");
                }
               
                // question 3
                if (THIS_SCRIPT == 'index' OR THIS_SCRIPT == 'forumdisplay')
                {
                // do something
                            $forumcounts= $DB_site->query("SELECT forumid, replycount, threadcount
                        FROM " . TABLE_PREFIX . "forum
                ");
                    while ($forumcount = $DB_site->fetch_array($forumcounts))
                    {
                              $forumreply[$forumcount[forumid]] = $forumcount[replycount];
                        $forumthread[$forumcount[forumid]] = $forumcount[threadcount];
                    }
}

// question 4
if ($bbuserinfo['userid'] != 1) {
        // question 5
        if (THIS_SCRIPT == 'adv_index')
                {
                        // do something
                            include("./forums/statistic_counter.php");
                }
        // question 6
        if (THIS_SCRIPT == 'index')
                {
                        // do something
                            include("./statistic_counter.php");
                }

}

// question 7
if (defined('IN_PORTAL_AREA')) {
        // do something
        require_once('./global.php');
}
thanks!

sabret00the 05-05-2005 07:09 PM
that's not bad at all :)

although i'm not sure about question 7, is that the vBglobal.php you're requiring?

Jenta 05-06-2005 08:13 AM
7 is vbportal which i have now abandoned all that !defined in portal area is gone now

good addon but i dont have the patience to do all the work to make it work like i want
ill just add 10 individual hacks to replace its funcionability :)

sabret00the 05-06-2005 10:25 AM
good luck :)


All times are GMT. The time now is 12:27 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.00899 seconds
  • Memory Usage 1,721KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (4)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete